[PR #445] [CLOSED] fix(scrollbar): don't handle arrow keys with modifiers #540

Closed
opened 2026-03-02 23:46:59 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/445
Author: @remorses
Created: 12/27/2025
Status: Closed

Base: mainHead: fix-scrollbar-modifier-keys


📝 Commits (1)

  • 9ee871b fix(scrollbar): don't handle arrow keys with modifiers

📊 Changes

1 file changed (+11 additions, -4 deletions)

View changed files

📝 packages/core/src/renderables/ScrollBar.ts (+11 -4)

📄 Description

Scrollbar was handling arrow keys (up/down/left/right) without checking for modifiers. This caused issues when modifier+arrow combinations were pressed:

  • shift+arrows should be for selection, not scrolling
  • cmd+arrows should be for navigation, not scrolling
  • ctrl+arrows should be for word movement, not scrolling

Now the scrollbar only handles plain arrow keys without any modifiers.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/445 **Author:** [@remorses](https://github.com/remorses) **Created:** 12/27/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix-scrollbar-modifier-keys` --- ### 📝 Commits (1) - [`9ee871b`](https://github.com/anomalyco/opentui/commit/9ee871b22f9307f098476e7524d5041019fcf9f7) fix(scrollbar): don't handle arrow keys with modifiers ### 📊 Changes **1 file changed** (+11 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/renderables/ScrollBar.ts` (+11 -4) </details> ### 📄 Description Scrollbar was handling arrow keys (up/down/left/right) without checking for modifiers. This caused issues when modifier+arrow combinations were pressed: - shift+arrows should be for selection, not scrolling - cmd+arrows should be for navigation, not scrolling - ctrl+arrows should be for word movement, not scrolling Now the scrollbar only handles plain arrow keys without any modifiers. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 23:46:59 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/opentui#540
No description provided.