[PR #424] [MERGED] rework some of the selection logic to native #528

New issue

Closed

opened 2026-03-02 23:46:55 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:46:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/424
Author: @kommander
Created: 12/18/2025
Status: ✅ Merged
Merged: 12/18/2025
Merged by: @kommander

Base: main ← Head: rework-selection-to-native

📝 Commits (8)

3e131ee update selection native
301c025 vie methods
4d70088 expose
046881f stash
7f7a87d stash
a6aaa1f stash
ddea7b8 fixup
8c91f9d cleanup

📊 Changes

19 files changed (+1465 additions, -304 deletions)

View changed files

📝 packages/core/src/editor-view.test.ts (+99 -3)
📝 packages/core/src/editor-view.ts (+25 -0)
📝 packages/core/src/lib/objects-in-viewport.test.ts (+61 -2)
📝 packages/core/src/lib/objects-in-viewport.ts (+11 -1)
📝 packages/core/src/lib/selection.ts (+29 -31)
📝 packages/core/src/renderables/Code.test.ts (+81 -2)
📝 packages/core/src/renderables/EditBufferRenderable.ts (+24 -46)
➕ packages/core/src/renderables/Text.selection-buffer.test.ts (+123 -0)
📝 packages/core/src/renderables/TextBufferRenderable.ts (+23 -4)
📝 packages/core/src/renderables/__tests__/Textarea.selection.test.ts (+232 -127)
📝 packages/core/src/renderer.ts (+4 -1)
📝 packages/core/src/text-buffer-view.test.ts (+104 -0)
📝 packages/core/src/text-buffer-view.ts (+25 -0)
📝 packages/core/src/zig.ts (+76 -0)
📝 packages/core/src/zig/buffer.zig (+0 -2)
📝 packages/core/src/zig/editor-view.zig (+41 -3)
📝 packages/core/src/zig/lib.zig (+24 -1)
📝 packages/core/src/zig/tests/text-buffer-selection_test.zig (+328 -27)
📝 packages/core/src/zig/text-buffer-view.zig (+155 -54)

📄 Description

in preparation for setting the cursor with mouse selections

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/424 **Author:** [@kommander](https://github.com/kommander) **Created:** 12/18/2025 **Status:** ✅ Merged **Merged:** 12/18/2025 **Merged by:** [@kommander](https://github.com/kommander) **Base:** `main` ← **Head:** `rework-selection-to-native` --- ### 📝 Commits (8) - [`3e131ee`](https://github.com/anomalyco/opentui/commit/3e131ee2e8369bf7e2e4c891c0989f5709659a0f) update selection native - [`301c025`](https://github.com/anomalyco/opentui/commit/301c02525bd248bfcd6a091329a99e44ed334e7f) vie methods - [`4d70088`](https://github.com/anomalyco/opentui/commit/4d70088d0299d6e2cea888ac8bb50a0e6abdfdb0) expose - [`046881f`](https://github.com/anomalyco/opentui/commit/046881fa786fef3229cdf2dac899c041e1f6e1dd) stash - [`7f7a87d`](https://github.com/anomalyco/opentui/commit/7f7a87d55293d6a75abc9be41d2302400d628bbf) stash - [`a6aaa1f`](https://github.com/anomalyco/opentui/commit/a6aaa1ffe1514a691450aea92c25ddb6259b7d2d) stash - [`ddea7b8`](https://github.com/anomalyco/opentui/commit/ddea7b85b1661420daf841d2b7a7f65cc9bce56c) fixup - [`8c91f9d`](https://github.com/anomalyco/opentui/commit/8c91f9d9b991c0dc054b06cb14e0f855f85972fd) cleanup ### 📊 Changes **19 files changed** (+1465 additions, -304 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/editor-view.test.ts` (+99 -3) 📝 `packages/core/src/editor-view.ts` (+25 -0) 📝 `packages/core/src/lib/objects-in-viewport.test.ts` (+61 -2) 📝 `packages/core/src/lib/objects-in-viewport.ts` (+11 -1) 📝 `packages/core/src/lib/selection.ts` (+29 -31) 📝 `packages/core/src/renderables/Code.test.ts` (+81 -2) 📝 `packages/core/src/renderables/EditBufferRenderable.ts` (+24 -46) ➕ `packages/core/src/renderables/Text.selection-buffer.test.ts` (+123 -0) 📝 `packages/core/src/renderables/TextBufferRenderable.ts` (+23 -4) 📝 `packages/core/src/renderables/__tests__/Textarea.selection.test.ts` (+232 -127) 📝 `packages/core/src/renderer.ts` (+4 -1) 📝 `packages/core/src/text-buffer-view.test.ts` (+104 -0) 📝 `packages/core/src/text-buffer-view.ts` (+25 -0) 📝 `packages/core/src/zig.ts` (+76 -0) 📝 `packages/core/src/zig/buffer.zig` (+0 -2) 📝 `packages/core/src/zig/editor-view.zig` (+41 -3) 📝 `packages/core/src/zig/lib.zig` (+24 -1) 📝 `packages/core/src/zig/tests/text-buffer-selection_test.zig` (+328 -27) 📝 `packages/core/src/zig/text-buffer-view.zig` (+155 -54) </details> ### 📄 Description in preparation for setting the cursor with mouse selections --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>