[PR #400] [MERGED] separate setText and replaceText for EditBuffer #513

New issue

Closed

opened 2026-03-02 23:46:51 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:46:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/400
Author: @kommander
Created: 12/10/2025
Status: ✅ Merged
Merged: 12/10/2025
Merged by: @kommander

Base: main ← Head: mem-reg

📝 Commits (10+)

cfe37e6 reproduce
3e5cc4d stash
730c0a3 no add_buffer leakage
a35fa5b extract mem reg
20986ff fix flaky tests
ae9a6b0 explicit mem reg tests
b53f0a3 allow unregister slots
34bb972 separate setText and replaceText
ed6dc5f additional test
976042c cleanup

📊 Changes

20 files changed (+1084 additions, -272 deletions)

View changed files

📝 packages/core/src/edit-buffer.test.ts (+131 -73)
📝 packages/core/src/edit-buffer.ts (+38 -16)
📝 packages/core/src/lib/extmarks.ts (+15 -5)
📝 packages/core/src/renderables/EditBufferRenderable.ts (+16 -2)
📝 packages/core/src/tests/scrollbox.test.ts (+4 -4)
📝 packages/core/src/zig.ts (+26 -8)
📝 packages/core/src/zig/bench/text-chunk-graphemes_bench.zig (+2 -1)
📝 packages/core/src/zig/edit-buffer.zig (+23 -12)
📝 packages/core/src/zig/lib.zig (+13 -4)
➕ packages/core/src/zig/mem-registry.zig (+125 -0)
📝 packages/core/src/zig/test.zig (+2 -0)
📝 packages/core/src/zig/tests/edit-buffer_test.zig (+141 -14)
📝 packages/core/src/zig/tests/editor-view_test.zig (+53 -53)
➕ packages/core/src/zig/tests/mem-registry_test.zig (+473 -0)
📝 packages/core/src/zig/tests/text-buffer-drawing_test.zig (+1 -1)
📝 packages/core/src/zig/tests/text-buffer_test.zig (+1 -1)
📝 packages/core/src/zig/tests/word-wrap-editing_test.zig (+13 -13)
📝 packages/core/src/zig/text-buffer-iterators.zig (+2 -1)
📝 packages/core/src/zig/text-buffer-segment.zig (+3 -63)
📝 packages/core/src/zig/text-buffer.zig (+2 -1)

📄 Description

The history: boolean option was confusing and let to weird ambiguous state.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/400 **Author:** [@kommander](https://github.com/kommander) **Created:** 12/10/2025 **Status:** ✅ Merged **Merged:** 12/10/2025 **Merged by:** [@kommander](https://github.com/kommander) **Base:** `main` ← **Head:** `mem-reg` --- ### 📝 Commits (10+) - [`cfe37e6`](https://github.com/anomalyco/opentui/commit/cfe37e66276021f9b778abf475a1ab1a219d92b5) reproduce - [`3e5cc4d`](https://github.com/anomalyco/opentui/commit/3e5cc4dd1a1847534bd3d5046aa0e1b1f078363e) stash - [`730c0a3`](https://github.com/anomalyco/opentui/commit/730c0a3919212d8fadfa78f6cbfb5cbb8264bbc9) no add_buffer leakage - [`a35fa5b`](https://github.com/anomalyco/opentui/commit/a35fa5b08c89f469111c552e92b33f477588b0f3) extract mem reg - [`20986ff`](https://github.com/anomalyco/opentui/commit/20986ff061675530e473f659ed1c600af280fff0) fix flaky tests - [`ae9a6b0`](https://github.com/anomalyco/opentui/commit/ae9a6b07f06f2351ba21d26b583f46435ee091d3) explicit mem reg tests - [`b53f0a3`](https://github.com/anomalyco/opentui/commit/b53f0a31ef99cae99ae7b6bf6d78b9962fa4d7e0) allow unregister slots - [`34bb972`](https://github.com/anomalyco/opentui/commit/34bb9727aae8d571288e792b2044d9f317eb3bd0) separate setText and replaceText - [`ed6dc5f`](https://github.com/anomalyco/opentui/commit/ed6dc5fc5406daacc76b50e760db2c6f4c681e05) additional test - [`976042c`](https://github.com/anomalyco/opentui/commit/976042c86e54012a37e7231f63d1e150b4912e87) cleanup ### 📊 Changes **20 files changed** (+1084 additions, -272 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/edit-buffer.test.ts` (+131 -73) 📝 `packages/core/src/edit-buffer.ts` (+38 -16) 📝 `packages/core/src/lib/extmarks.ts` (+15 -5) 📝 `packages/core/src/renderables/EditBufferRenderable.ts` (+16 -2) 📝 `packages/core/src/tests/scrollbox.test.ts` (+4 -4) 📝 `packages/core/src/zig.ts` (+26 -8) 📝 `packages/core/src/zig/bench/text-chunk-graphemes_bench.zig` (+2 -1) 📝 `packages/core/src/zig/edit-buffer.zig` (+23 -12) 📝 `packages/core/src/zig/lib.zig` (+13 -4) ➕ `packages/core/src/zig/mem-registry.zig` (+125 -0) 📝 `packages/core/src/zig/test.zig` (+2 -0) 📝 `packages/core/src/zig/tests/edit-buffer_test.zig` (+141 -14) 📝 `packages/core/src/zig/tests/editor-view_test.zig` (+53 -53) ➕ `packages/core/src/zig/tests/mem-registry_test.zig` (+473 -0) 📝 `packages/core/src/zig/tests/text-buffer-drawing_test.zig` (+1 -1) 📝 `packages/core/src/zig/tests/text-buffer_test.zig` (+1 -1) 📝 `packages/core/src/zig/tests/word-wrap-editing_test.zig` (+13 -13) 📝 `packages/core/src/zig/text-buffer-iterators.zig` (+2 -1) 📝 `packages/core/src/zig/text-buffer-segment.zig` (+3 -63) 📝 `packages/core/src/zig/text-buffer.zig` (+2 -1) </details> ### 📄 Description The `history: boolean` option was confusing and let to weird ambiguous state. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>