[GH-ISSUE #213] Why doesn't the resize function use the size argument? #49

New issue

Closed

opened 2026-03-02 23:44:08 +03:00 by kerem · 2 comments

kerem commented

2026-03-02 23:44:08 +03:00

Owner

Originally created by @aprogramq on GitHub (Oct 11, 2025).
Original GitHub issue: https://github.com/anomalyco/opentui/issues/213

Hi, sorry for my possibly stupid question, but I don't understand why the resize function in the TerminalConsole class doesn't use the width and height arguments. Thanks in advance.

public resize(width: number, height: number): void {
    this._updateConsoleDimensions()

    if (this.frameBuffer) {
      this.frameBuffer.resize(this.consoleWidth, this.consoleHeight)

      const displayLineCount = this._displayLines.length
      const logAreaHeight = Math.max(1, this.consoleHeight - 1)
      const maxScrollTop = Math.max(0, displayLineCount - logAreaHeight)
      this.scrollTopIndex = Math.min(this.scrollTopIndex, maxScrollTop)
      this.isScrolledToBottom = this.scrollTopIndex === maxScrollTop
      const visibleLineCount = Math.min(logAreaHeight, displayLineCount - this.scrollTopIndex)
      this.currentLineIndex = Math.max(0, Math.min(this.currentLineIndex, visibleLineCount - 1))

      if (this.isVisible) {
        this.markNeedsRerender()
      }
    }
  }

Originally created by @aprogramq on GitHub (Oct 11, 2025). Original GitHub issue: https://github.com/anomalyco/opentui/issues/213 Hi, sorry for my possibly stupid question, but I don't understand why the resize function in the TerminalConsole class doesn't use the width and height arguments. Thanks in advance. ``` public resize(width: number, height: number): void { this._updateConsoleDimensions() if (this.frameBuffer) { this.frameBuffer.resize(this.consoleWidth, this.consoleHeight) const displayLineCount = this._displayLines.length const logAreaHeight = Math.max(1, this.consoleHeight - 1) const maxScrollTop = Math.max(0, displayLineCount - logAreaHeight) this.scrollTopIndex = Math.min(this.scrollTopIndex, maxScrollTop) this.isScrolledToBottom = this.scrollTopIndex === maxScrollTop const visibleLineCount = Math.min(logAreaHeight, displayLineCount - this.scrollTopIndex) this.currentLineIndex = Math.max(0, Math.min(this.currentLineIndex, visibleLineCount - 1)) if (this.isVisible) { this.markNeedsRerender() } } } ```

kerem

2026-03-02 23:44:08 +03:00

closed this issue
added the
feature

core

good first issue
labels

kerem commented

2026-03-02 23:44:10 +03:00

Author

Owner

@kommander commented on GitHub (Oct 11, 2025):

It probably should, it uses renderer.terminalWidth/Height to update dimensions currently. Haven't touched that in a while.

@kommander commented on GitHub (Oct 11, 2025): It probably should, it uses `renderer.terminalWidth/Height` to update dimensions currently. Haven't touched that in a while.

kerem commented

2026-03-02 23:44:10 +03:00

Author

Owner

@aymuos15 commented on GitHub (Nov 1, 2025):

Could I be assigned to this please?

@aymuos15 commented on GitHub (Nov 1, 2025): Could I be assigned to this please?

kerem referenced this issue

2026-03-02 23:45:36 +03:00

[PR #49] [MERGED] Fix solid text breaking due to Immutable styled text #248

kerem referenced this issue

2026-03-14 09:14:34 +03:00