[PR #188] [MERGED] Fix(core): Some children not getting destroyed #356

New issue

Closed

opened 2026-03-02 23:46:07 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:46:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/188
Author: @Adictya
Created: 9/29/2025
Status: ✅ Merged
Merged: 9/29/2025
Merged by: @Adictya

Base: main ← Head: core-children-destroy-order-fix

📝 Commits (2)

9e717c3 fix(core): Mutating and iterating same array in destroy recursive
18038c7 chore(core): Remove extra test

📊 Changes

3 files changed (+101 additions, -1 deletions)

View changed files

📝 packages/core/src/Renderable.ts (+3 -1)
📝 packages/core/src/tests/renderable.test.ts (+49 -0)
➕ packages/core/src/tests/scrollbox.test.ts (+49 -0)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/188 **Author:** [@Adictya](https://github.com/Adictya) **Created:** 9/29/2025 **Status:** ✅ Merged **Merged:** 9/29/2025 **Merged by:** [@Adictya](https://github.com/Adictya) **Base:** `main` ← **Head:** `core-children-destroy-order-fix` --- ### 📝 Commits (2) - [`9e717c3`](https://github.com/anomalyco/opentui/commit/9e717c3037da095df561da34b2c06341c9a3cb78) fix(core): Mutating and iterating same array in destroy recursive - [`18038c7`](https://github.com/anomalyco/opentui/commit/18038c79126ed7a2520454fd584eb56be9ef3695) chore(core): Remove extra test ### 📊 Changes **3 files changed** (+101 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/Renderable.ts` (+3 -1) 📝 `packages/core/src/tests/renderable.test.ts` (+49 -0) ➕ `packages/core/src/tests/scrollbox.test.ts` (+49 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>