[PR #182] [MERGED] Allow preventDefault on global key handler to not trigger focused renderables #354

New issue

Closed

opened 2026-03-02 23:46:06 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:46:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/182
Author: @kommander
Created: 9/24/2025
Status: ✅ Merged
Merged: 9/24/2025
Merged by: @kommander

Base: main ← Head: key-event-handling

📝 Commits (8)

f3e40f2 introduce KeyEvent
c97cea3 stash
bc0122f internal handler
576a7e8 test cover
a020940 introduce paste event
24e450f cleanup
18a8d66 fix solid
c83464c over solid preventDefault

📊 Changes

29 files changed (+999 additions, -176 deletions)

View changed files

📝 packages/core/docs/getting-started.md (+2 -2)
📝 packages/core/src/Renderable.ts (+16 -16)
📝 packages/core/src/examples/hast-syntax-highlighting-demo.ts (+3 -3)
📝 packages/core/src/examples/index.ts (+2 -2)
📝 packages/core/src/examples/input-select-layout-demo.ts (+2 -2)
📝 packages/core/src/examples/lib/standalone-keys.ts (+2 -2)
📝 packages/core/src/examples/simple-layout-example.ts (+2 -2)
📝 packages/core/src/examples/styled-text-demo.ts (+3 -3)
📝 packages/core/src/lib/KeyHandler.test.ts (+252 -20)
📝 packages/core/src/lib/KeyHandler.ts (+134 -17)
📝 packages/core/src/lib/parse.keypress-kitty.ts (+0 -1)
📝 packages/core/src/lib/parse.keypress.ts (+1 -1)
📝 packages/core/src/renderables/Input.test.ts (+205 -0)
📝 packages/core/src/renderables/Input.ts (+2 -2)
📝 packages/core/src/renderables/ScrollBar.ts (+2 -2)
📝 packages/core/src/renderables/ScrollBox.ts (+2 -2)
📝 packages/core/src/renderables/Select.ts (+2 -2)
📝 packages/core/src/renderables/TabSelect.ts (+2 -2)
📝 packages/core/src/renderer.ts (+7 -3)
📝 packages/core/src/tests/renderer.input.test.ts (+74 -73)

...and 9 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/182 **Author:** [@kommander](https://github.com/kommander) **Created:** 9/24/2025 **Status:** ✅ Merged **Merged:** 9/24/2025 **Merged by:** [@kommander](https://github.com/kommander) **Base:** `main` ← **Head:** `key-event-handling` --- ### 📝 Commits (8) - [`f3e40f2`](https://github.com/anomalyco/opentui/commit/f3e40f2a2ec15e0df9703ac7be7dad291765caed) introduce KeyEvent - [`c97cea3`](https://github.com/anomalyco/opentui/commit/c97cea3628c86dd9f5fb901a753984e269acae00) stash - [`bc0122f`](https://github.com/anomalyco/opentui/commit/bc0122ff51137a71ab1e77807e48a15aa9e3a7d8) internal handler - [`576a7e8`](https://github.com/anomalyco/opentui/commit/576a7e8b9c568dd4d88017965779cb3cc26a24e2) test cover - [`a020940`](https://github.com/anomalyco/opentui/commit/a02094091ac556836245af0a196f57353aff8a56) introduce paste event - [`24e450f`](https://github.com/anomalyco/opentui/commit/24e450f759dee1672cef86b8010f18cf40fc3948) cleanup - [`18a8d66`](https://github.com/anomalyco/opentui/commit/18a8d66000edf05d05ac0f18b00164fc04fcfced) fix solid - [`c83464c`](https://github.com/anomalyco/opentui/commit/c83464cafcaf02c830ceb4eee6e3dfbe50f9ea87) over solid preventDefault ### 📊 Changes **29 files changed** (+999 additions, -176 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/docs/getting-started.md` (+2 -2) 📝 `packages/core/src/Renderable.ts` (+16 -16) 📝 `packages/core/src/examples/hast-syntax-highlighting-demo.ts` (+3 -3) 📝 `packages/core/src/examples/index.ts` (+2 -2) 📝 `packages/core/src/examples/input-select-layout-demo.ts` (+2 -2) 📝 `packages/core/src/examples/lib/standalone-keys.ts` (+2 -2) 📝 `packages/core/src/examples/simple-layout-example.ts` (+2 -2) 📝 `packages/core/src/examples/styled-text-demo.ts` (+3 -3) 📝 `packages/core/src/lib/KeyHandler.test.ts` (+252 -20) 📝 `packages/core/src/lib/KeyHandler.ts` (+134 -17) 📝 `packages/core/src/lib/parse.keypress-kitty.ts` (+0 -1) 📝 `packages/core/src/lib/parse.keypress.ts` (+1 -1) 📝 `packages/core/src/renderables/Input.test.ts` (+205 -0) 📝 `packages/core/src/renderables/Input.ts` (+2 -2) 📝 `packages/core/src/renderables/ScrollBar.ts` (+2 -2) 📝 `packages/core/src/renderables/ScrollBox.ts` (+2 -2) 📝 `packages/core/src/renderables/Select.ts` (+2 -2) 📝 `packages/core/src/renderables/TabSelect.ts` (+2 -2) 📝 `packages/core/src/renderer.ts` (+7 -3) 📝 `packages/core/src/tests/renderer.input.test.ts` (+74 -73) _...and 9 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>