[PR #176] [MERGED] Fix(solid): Solid slot lifecycle fix #348

New issue

Closed

opened 2026-03-02 23:46:05 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:46:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/176
Author: @Adictya
Created: 9/22/2025
Status: ✅ Merged
Merged: 9/22/2025
Merged by: @kommander

Base: main ← Head: solid-slot-parent-fix

📝 Commits (2)

44aa8c8 fix(solid): smol solid slot parent fix
e8ef1ec fix(core): console capture

📊 Changes

3 files changed (+11 additions, -22 deletions)

View changed files

📝 packages/core/src/console.ts (+2 -1)
📝 packages/solid/src/reconciler.ts (+2 -0)
📝 packages/solid/tests/control-flow.test.tsx (+7 -21)

📄 Description

Slot elements weren't being replaced. This fixes it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/176 **Author:** [@Adictya](https://github.com/Adictya) **Created:** 9/22/2025 **Status:** ✅ Merged **Merged:** 9/22/2025 **Merged by:** [@kommander](https://github.com/kommander) **Base:** `main` ← **Head:** `solid-slot-parent-fix` --- ### 📝 Commits (2) - [`44aa8c8`](https://github.com/anomalyco/opentui/commit/44aa8c82b144f95cee9377f763637e3c619b5788) fix(solid): smol solid slot parent fix - [`e8ef1ec`](https://github.com/anomalyco/opentui/commit/e8ef1ec6805b8ba68ee4cc9b5b61c34ba9ca7bea) fix(core): console capture ### 📊 Changes **3 files changed** (+11 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/console.ts` (+2 -1) 📝 `packages/solid/src/reconciler.ts` (+2 -0) 📝 `packages/solid/tests/control-flow.test.tsx` (+7 -21) </details> ### 📄 Description Slot elements weren't being replaced. This fixes it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>