[PR #155] [MERGED] Fix text node rendering in Solid #327

New issue

Closed

opened 2026-03-02 23:45:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:45:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/155
Author: @fezproof
Created: 9/11/2025
Status: ✅ Merged
Merged: 9/12/2025
Merged by: @fezproof

Base: main ← Head: fix-text-node-rendering

📝 Commits (10+)

46828bd WIP Move to text nodes
42cff0f Update text style demo
146f8e5 WIP
df616f9 Fix throw on empty text nodes
a35fcfe Fix store export using server
7cc1750 Clean up session example to be efficient
a942818 Fix last of the text bugs
f44fa2b Remove debug
d979cba Remove text node
ed10f8d Clean up types

📊 Changes

14 files changed (+248 additions, -417 deletions)

View changed files

📝 packages/core/src/Renderable.ts (+1 -0)
📝 packages/core/src/renderables/Text.ts (+16 -6)
📝 packages/core/src/renderables/TextNode.ts (+13 -0)
📝 packages/solid/examples/components/text-selection-demo.tsx (+14 -10)
📝 packages/solid/examples/components/text-style-demo.tsx (+14 -10)
📝 packages/solid/examples/repro-empty-styled-text.tsx (+2 -2)
📝 packages/solid/examples/session.tsx (+63 -55)
📝 packages/solid/index.ts (+0 -1)
📝 packages/solid/jsx-runtime.d.ts (+5 -2)
📝 packages/solid/scripts/solid-plugin.ts (+6 -0)
📝 packages/solid/src/elements/index.ts (+14 -0)
➖ packages/solid/src/elements/text-node.ts (+0 -180)
📝 packages/solid/src/reconciler.ts (+88 -143)
📝 packages/solid/src/types/elements.ts (+12 -8)

📄 Description

https://github.com/user-attachments/assets/161493a4-1e47-4c25-98de-b70e67fdcb07

Adds <span> element
Makes it so only <text> can have text

You can no longer used styled text directly in the renderer, you must use span. This can be fixed later

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/155 **Author:** [@fezproof](https://github.com/fezproof) **Created:** 9/11/2025 **Status:** ✅ Merged **Merged:** 9/12/2025 **Merged by:** [@fezproof](https://github.com/fezproof) **Base:** `main` ← **Head:** `fix-text-node-rendering` --- ### 📝 Commits (10+) - [`46828bd`](https://github.com/anomalyco/opentui/commit/46828bdd4f2fb3427b74ea0f743ce13caedc1d44) WIP Move to text nodes - [`42cff0f`](https://github.com/anomalyco/opentui/commit/42cff0fdc336b7b8b1c668003a3c6e5967122065) Update text style demo - [`146f8e5`](https://github.com/anomalyco/opentui/commit/146f8e5a465c8200a7b9fad15044e629fe3e4d2a) WIP - [`df616f9`](https://github.com/anomalyco/opentui/commit/df616f931e10a70e76193a93bd53a96c3810fdde) Fix throw on empty text nodes - [`a35fcfe`](https://github.com/anomalyco/opentui/commit/a35fcfe89fff7b37b2546b9d292da921edceff77) Fix store export using server - [`7cc1750`](https://github.com/anomalyco/opentui/commit/7cc175037abc48ad2da9569927c73cc3dbd0e4ca) Clean up session example to be efficient - [`a942818`](https://github.com/anomalyco/opentui/commit/a9428184e88a6f65a1c10f330b84f36980ac1550) Fix last of the text bugs - [`f44fa2b`](https://github.com/anomalyco/opentui/commit/f44fa2bfdd253d29600da670998affe28400528b) Remove debug - [`d979cba`](https://github.com/anomalyco/opentui/commit/d979cba96e8491d7cbf3d6f56e3ebab4a458b9e8) Remove text node - [`ed10f8d`](https://github.com/anomalyco/opentui/commit/ed10f8d5c2223f323783d5162052d94889a95841) Clean up types ### 📊 Changes **14 files changed** (+248 additions, -417 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/Renderable.ts` (+1 -0) 📝 `packages/core/src/renderables/Text.ts` (+16 -6) 📝 `packages/core/src/renderables/TextNode.ts` (+13 -0) 📝 `packages/solid/examples/components/text-selection-demo.tsx` (+14 -10) 📝 `packages/solid/examples/components/text-style-demo.tsx` (+14 -10) 📝 `packages/solid/examples/repro-empty-styled-text.tsx` (+2 -2) 📝 `packages/solid/examples/session.tsx` (+63 -55) 📝 `packages/solid/index.ts` (+0 -1) 📝 `packages/solid/jsx-runtime.d.ts` (+5 -2) 📝 `packages/solid/scripts/solid-plugin.ts` (+6 -0) 📝 `packages/solid/src/elements/index.ts` (+14 -0) ➖ `packages/solid/src/elements/text-node.ts` (+0 -180) 📝 `packages/solid/src/reconciler.ts` (+88 -143) 📝 `packages/solid/src/types/elements.ts` (+12 -8) </details> ### 📄 Description https://github.com/user-attachments/assets/161493a4-1e47-4c25-98de-b70e67fdcb07 Adds `<span>` element Makes it so only `<text>` can have text You can no longer used styled text directly in the renderer, you must use span. This can be fixed later --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>