[PR #108] [MERGED] Fix reactive component conditional rendering issue #293

New issue

Closed

opened 2026-03-02 23:45:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:45:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/108
Author: @Adictya
Created: 8/30/2025
Status: ✅ Merged
Merged: 8/31/2025
Merged by: @Adictya

Base: main ← Head: solid-show-component-issue-fix

📝 Commits (4)

d42e007 fix nested show issue
5444056 chore lint
d2949e4 address review feedback
ce50562 fix exported var name

📊 Changes

2 files changed (+114 additions, -82 deletions)

View changed files

📝 packages/solid/src/elements/text-node.ts (+7 -0)
📝 packages/solid/src/reconciler.ts (+107 -82)

📄 Description

Also fixes a small bug with empty text renderables

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/108 **Author:** [@Adictya](https://github.com/Adictya) **Created:** 8/30/2025 **Status:** ✅ Merged **Merged:** 8/31/2025 **Merged by:** [@Adictya](https://github.com/Adictya) **Base:** `main` ← **Head:** `solid-show-component-issue-fix` --- ### 📝 Commits (4) - [`d42e007`](https://github.com/anomalyco/opentui/commit/d42e007a4fe0def5eac3ddae29fb95138c74198b) fix nested show issue - [`5444056`](https://github.com/anomalyco/opentui/commit/5444056083fb5f53a75fa7c6b2a28ba1df49a74c) chore lint - [`d2949e4`](https://github.com/anomalyco/opentui/commit/d2949e49daba07b0b257409b9ac0e8fbb2bb3065) address review feedback - [`ce50562`](https://github.com/anomalyco/opentui/commit/ce505626f939fc51b897722252db6a0c820c9229) fix exported var name ### 📊 Changes **2 files changed** (+114 additions, -82 deletions) <details> <summary>View changed files</summary> 📝 `packages/solid/src/elements/text-node.ts` (+7 -0) 📝 `packages/solid/src/reconciler.ts` (+107 -82) </details> ### 📄 Description - Also fixes a small bug with empty text renderables --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>