[PR #73] [MERGED] fix: fallback to default values when properties undefined #270

New issue

Closed

opened 2026-03-02 23:45:42 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:45:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/73
Author: @msmps
Created: 8/25/2025
Status: ✅ Merged
Merged: 8/25/2025
Merged by: @msmps

Base: main ← Head: fix/default-options-20250825082410

📝 Commits (8)

c569985 fix(box): fallback to default when undefined
9c00bf4 fix(input): fallback to default when undefined
9adf217 fix: remove unnecessary null check
95a96d6 fix(box): set border to false by default
9826865 fix(examples): update examples to respect new border default
4786e6a fix: update solid/react examples
1458f6d fix: account for extended renderables
cbd6584 fix: solid examples

📊 Changes

30 files changed (+182 additions, -82 deletions)

View changed files

📝 packages/core/src/examples/ascii-font-selection-demo.ts (+2 -0)
📝 packages/core/src/examples/console-demo.ts (+1 -0)
📝 packages/core/src/examples/hast-syntax-highlighting-demo.ts (+2 -0)
📝 packages/core/src/examples/index.ts (+1 -0)
📝 packages/core/src/examples/input-select-layout-demo.ts (+7 -0)
📝 packages/core/src/examples/live-state-demo.ts (+2 -1)
📝 packages/core/src/examples/mouse-interaction-demo.ts (+1 -0)
📝 packages/core/src/examples/nested-zindex-demo.ts (+6 -0)
📝 packages/core/src/examples/opentui-demo.ts (+15 -0)
📝 packages/core/src/examples/relative-positioning-demo.ts (+6 -0)
📝 packages/core/src/examples/shader-cube-demo.ts (+1 -0)
📝 packages/core/src/examples/simple-layout-example.ts (+7 -0)
📝 packages/core/src/examples/split-mode-demo.ts (+2 -4)
📝 packages/core/src/examples/styled-text-demo.ts (+1 -0)
📝 packages/core/src/examples/text-selection-demo.ts (+6 -0)
📝 packages/core/src/examples/timeline-example.ts (+0 -3)
📝 packages/core/src/examples/transparency-demo.ts (+1 -1)
📝 packages/core/src/renderables/Box.ts (+31 -22)
📝 packages/core/src/renderables/Input.ts (+62 -28)
📝 packages/react/examples/ascii.tsx (+1 -0)

...and 10 more files

📄 Description

Description

this largely covers color properties as others either respect undefined when passed or undefined is absurd
sets border to false by default on box renderable

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/73 **Author:** [@msmps](https://github.com/msmps) **Created:** 8/25/2025 **Status:** ✅ Merged **Merged:** 8/25/2025 **Merged by:** [@msmps](https://github.com/msmps) **Base:** `main` ← **Head:** `fix/default-options-20250825082410` --- ### 📝 Commits (8) - [`c569985`](https://github.com/anomalyco/opentui/commit/c569985e88e301cc39a7abe77f10331e2780fb67) fix(box): fallback to default when undefined - [`9c00bf4`](https://github.com/anomalyco/opentui/commit/9c00bf439bcada0d2ae041ddb9e7da5eefee99f8) fix(input): fallback to default when undefined - [`9adf217`](https://github.com/anomalyco/opentui/commit/9adf21709439f673e19dd72c0e4d0b30abe7c6a8) fix: remove unnecessary null check - [`95a96d6`](https://github.com/anomalyco/opentui/commit/95a96d6f349db40c470b1bebb08ab6ffd399c215) fix(box): set border to false by default - [`9826865`](https://github.com/anomalyco/opentui/commit/9826865a31674989363861842b9ed37c459617d2) fix(examples): update examples to respect new border default - [`4786e6a`](https://github.com/anomalyco/opentui/commit/4786e6a68e7b56f4700433442b38e8977a095b6f) fix: update solid/react examples - [`1458f6d`](https://github.com/anomalyco/opentui/commit/1458f6d7f3e10882c7d341956c2320b5f197ade8) fix: account for extended renderables - [`cbd6584`](https://github.com/anomalyco/opentui/commit/cbd6584611b8bc2572f0aa9fcc50e649034aef81) fix: solid examples ### 📊 Changes **30 files changed** (+182 additions, -82 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/examples/ascii-font-selection-demo.ts` (+2 -0) 📝 `packages/core/src/examples/console-demo.ts` (+1 -0) 📝 `packages/core/src/examples/hast-syntax-highlighting-demo.ts` (+2 -0) 📝 `packages/core/src/examples/index.ts` (+1 -0) 📝 `packages/core/src/examples/input-select-layout-demo.ts` (+7 -0) 📝 `packages/core/src/examples/live-state-demo.ts` (+2 -1) 📝 `packages/core/src/examples/mouse-interaction-demo.ts` (+1 -0) 📝 `packages/core/src/examples/nested-zindex-demo.ts` (+6 -0) 📝 `packages/core/src/examples/opentui-demo.ts` (+15 -0) 📝 `packages/core/src/examples/relative-positioning-demo.ts` (+6 -0) 📝 `packages/core/src/examples/shader-cube-demo.ts` (+1 -0) 📝 `packages/core/src/examples/simple-layout-example.ts` (+7 -0) 📝 `packages/core/src/examples/split-mode-demo.ts` (+2 -4) 📝 `packages/core/src/examples/styled-text-demo.ts` (+1 -0) 📝 `packages/core/src/examples/text-selection-demo.ts` (+6 -0) 📝 `packages/core/src/examples/timeline-example.ts` (+0 -3) 📝 `packages/core/src/examples/transparency-demo.ts` (+1 -1) 📝 `packages/core/src/renderables/Box.ts` (+31 -22) 📝 `packages/core/src/renderables/Input.ts` (+62 -28) 📝 `packages/react/examples/ascii.tsx` (+1 -0) _...and 10 more files_ </details> ### 📄 Description ## Description - this largely covers color properties as others either respect undefined when passed or undefined is absurd - sets `border` to false by default on `box` renderable --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>