[PR #61] [MERGED] fix: update cursor position after layout change #260

Closed
opened 2026-03-02 23:45:39 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/61
Author: @KurtGokhan
Created: 8/24/2025
Status: Merged
Merged: 8/24/2025
Merged by: @kommander

Base: mainHead: update-cursor-position-after-layout-change


📝 Commits (2)

  • a6987c5 fix: update cursor position when input layout changes
  • cd043d2 prettier fixes

📊 Changes

6 files changed (+25 additions, -16 deletions)

View changed files

📝 packages/core/src/console.ts (+5 -6)
📝 packages/core/src/lib/KeyHandler.ts (+1 -1)
📝 packages/core/src/renderables/Input.ts (+10 -0)
📝 packages/core/src/renderer.ts (+3 -3)
📝 packages/core/src/singleton.ts (+2 -2)
📝 packages/solid/scripts/solid-plugin.ts (+4 -4)

📄 Description

I noticed cursor position doesn't update after the position of the input element changes. This is noticable especially when resizing the terminal.

Before:

https://github.com/user-attachments/assets/067bc60f-451b-4722-84f7-9afe48013507

After:

https://github.com/user-attachments/assets/d1b82852-340f-482e-9c45-6eb128c29e09

  • Also, I fumbled the prettier formatting in my previous PR. Fixed them in the second commit.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/61 **Author:** [@KurtGokhan](https://github.com/KurtGokhan) **Created:** 8/24/2025 **Status:** ✅ Merged **Merged:** 8/24/2025 **Merged by:** [@kommander](https://github.com/kommander) **Base:** `main` ← **Head:** `update-cursor-position-after-layout-change` --- ### 📝 Commits (2) - [`a6987c5`](https://github.com/anomalyco/opentui/commit/a6987c5675bf2801696bf213aa29f6e0b1c81cc6) fix: update cursor position when input layout changes - [`cd043d2`](https://github.com/anomalyco/opentui/commit/cd043d2770132565aa8888d6fe73e96cef637811) prettier fixes ### 📊 Changes **6 files changed** (+25 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/console.ts` (+5 -6) 📝 `packages/core/src/lib/KeyHandler.ts` (+1 -1) 📝 `packages/core/src/renderables/Input.ts` (+10 -0) 📝 `packages/core/src/renderer.ts` (+3 -3) 📝 `packages/core/src/singleton.ts` (+2 -2) 📝 `packages/solid/scripts/solid-plugin.ts` (+4 -4) </details> ### 📄 Description I noticed cursor position doesn't update after the position of the input element changes. This is noticable especially when resizing the terminal. Before: https://github.com/user-attachments/assets/067bc60f-451b-4722-84f7-9afe48013507 After: https://github.com/user-attachments/assets/d1b82852-340f-482e-9c45-6eb128c29e09 - Also, I fumbled the prettier formatting in my previous PR. Fixed them in the second commit. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 23:45:39 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/opentui#260
No description provided.