[PR #42] [MERGED] Make it so you can now write text anywhere using solid #243

New issue

Closed

opened 2026-03-02 23:45:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:45:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/42
Author: @fezproof
Created: 8/19/2025
Status: ✅ Merged
Merged: 8/19/2025
Merged by: @kommander

Base: main ← Head: imporve-text-nodes

📝 Commits (6)

c88eba0 Install
ce915a9 Added reconciler code to support ghost text nodes
01b0cee Remove some magic strings
323267e Fix rerendering bug
a16e33d Update text style demo to handle unparented text
c10631b Fix prepend to node not checking for ghost

📊 Changes

4 files changed (+135 additions, -62 deletions)

View changed files

📝 bun.lock (+16 -16)
📝 packages/core/src/renderables/Text.ts (+1 -1)
📝 packages/solid/examples/components/text-style-demo.tsx (+5 -1)
📝 packages/solid/src/reconciler.ts (+113 -44)

📄 Description

Add "ghost" text nodes if the text parent is not a text renderable
Handle cleanup of text nodes
Handle anchoring to text nodes properly
Fix bug where text is not updating properly

Let me know if you want me to clean up this code, its a bit messy

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/42 **Author:** [@fezproof](https://github.com/fezproof) **Created:** 8/19/2025 **Status:** ✅ Merged **Merged:** 8/19/2025 **Merged by:** [@kommander](https://github.com/kommander) **Base:** `main` ← **Head:** `imporve-text-nodes` --- ### 📝 Commits (6) - [`c88eba0`](https://github.com/anomalyco/opentui/commit/c88eba05e8cba093979c0bb5af8241fd3e2956b2) Install - [`ce915a9`](https://github.com/anomalyco/opentui/commit/ce915a9dde42daefe075c2dcd6624bcdd8e3f4ec) Added reconciler code to support ghost text nodes - [`01b0cee`](https://github.com/anomalyco/opentui/commit/01b0cee5cd8fbcae67e458d34972bbbaae174535) Remove some magic strings - [`323267e`](https://github.com/anomalyco/opentui/commit/323267e06d7369501e7d3938ec28baea34494678) Fix rerendering bug - [`a16e33d`](https://github.com/anomalyco/opentui/commit/a16e33de27db6e75c1c02aa4ae03f966da5ad792) Update text style demo to handle unparented text - [`c10631b`](https://github.com/anomalyco/opentui/commit/c10631bcb7136b91a77aa60ba49cc1c35ad6b8d7) Fix prepend to node not checking for ghost ### 📊 Changes **4 files changed** (+135 additions, -62 deletions) <details> <summary>View changed files</summary> 📝 `bun.lock` (+16 -16) 📝 `packages/core/src/renderables/Text.ts` (+1 -1) 📝 `packages/solid/examples/components/text-style-demo.tsx` (+5 -1) 📝 `packages/solid/src/reconciler.ts` (+113 -44) </details> ### 📄 Description Add "ghost" text nodes if the text parent is not a text renderable Handle cleanup of text nodes Handle anchoring to text nodes properly Fix bug where text is not updating properly Let me know if you want me to clean up this code, its a bit messy --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>