[PR #13] [MERGED] chore(select): implement get/set #219

Closed
opened 2026-03-02 23:45:28 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/13
Author: @msmps
Created: 8/14/2025
Status: Merged
Merged: 8/14/2025
Merged by: @kommander

Base: mainHead: feat/add-setters-20250814172325


📝 Commits (2)

  • e09b34c chore(select): implement get/set
  • b4990df chore: update private variables that were missed

📊 Changes

2 files changed (+162 additions, -75 deletions)

View changed files

📝 src/examples/select-demo.ts (+9 -9)
📝 src/renderables/Select.ts (+153 -66)

📄 Description

Description

  • refactored SelectRenderable class to use getters/setters instead of explicit get/set methods
  • added additional property setters for all configurable properties of the SelectRenderable

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/13 **Author:** [@msmps](https://github.com/msmps) **Created:** 8/14/2025 **Status:** ✅ Merged **Merged:** 8/14/2025 **Merged by:** [@kommander](https://github.com/kommander) **Base:** `main` ← **Head:** `feat/add-setters-20250814172325` --- ### 📝 Commits (2) - [`e09b34c`](https://github.com/anomalyco/opentui/commit/e09b34cdb164ea5e5bc415a483c15287e3c69b0b) chore(select): implement get/set - [`b4990df`](https://github.com/anomalyco/opentui/commit/b4990dfabc038b77f025ad1708fc7e2b8ed34269) chore: update private variables that were missed ### 📊 Changes **2 files changed** (+162 additions, -75 deletions) <details> <summary>View changed files</summary> 📝 `src/examples/select-demo.ts` (+9 -9) 📝 `src/renderables/Select.ts` (+153 -66) </details> ### 📄 Description ## Description - refactored `SelectRenderable` class to use getters/setters instead of explicit get/set methods - added additional property setters for all configurable properties of the `SelectRenderable` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 23:45:28 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/opentui#219
No description provided.