[PR #787] [MERGED] harden solid dispose/renderer destruction handling #1562

New issue

Closed

opened 2026-03-14 09:43:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 09:43:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/787
Author: @kommander
Created: 3/6/2026
Status: ✅ Merged
Merged: 3/7/2026
Merged by: @kommander

Base: main ← Head: child-node-measure-function-error

📝 Commits (7)

6051aff cover some
43f5db9 repro
3893b39 cover more
d68b96a dispose controller
abf12d3 simplify
369fb44 prettier
e4d2c52 cover more

📊 Changes

5 files changed (+413 additions, -48 deletions)

View changed files

📝 packages/solid/index.ts (+66 -47)
➕ packages/solid/tests/destroy-crash.test.tsx (+96 -0)
➕ packages/solid/tests/destroy-race-repro.test.ts (+66 -0)
➕ packages/solid/tests/destroy-race.fixture.tsx (+177 -0)
📝 packages/web/src/content/docs/components/line-number.mdx (+8 -1)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/787 **Author:** [@kommander](https://github.com/kommander) **Created:** 3/6/2026 **Status:** ✅ Merged **Merged:** 3/7/2026 **Merged by:** [@kommander](https://github.com/kommander) **Base:** `main` ← **Head:** `child-node-measure-function-error` --- ### 📝 Commits (7) - [`6051aff`](https://github.com/anomalyco/opentui/commit/6051aff1dd3c9b760e159aa3b53ed642df63c527) cover some - [`43f5db9`](https://github.com/anomalyco/opentui/commit/43f5db98cc45cb75f3bd362548aba98d303d3c71) repro - [`3893b39`](https://github.com/anomalyco/opentui/commit/3893b392ca0d9320242b324ba4b5786d7d219bf0) cover more - [`d68b96a`](https://github.com/anomalyco/opentui/commit/d68b96a2aab95e783a7018cd827ab1e84e85ab8e) dispose controller - [`abf12d3`](https://github.com/anomalyco/opentui/commit/abf12d3fdbf34c81ab797ada0a047928b9a2f8fa) simplify - [`369fb44`](https://github.com/anomalyco/opentui/commit/369fb441d2deca71d0b2e4cd07d3c87c07a8d643) prettier - [`e4d2c52`](https://github.com/anomalyco/opentui/commit/e4d2c526b3ee3a45690cdf69d8871ada8ed9130d) cover more ### 📊 Changes **5 files changed** (+413 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `packages/solid/index.ts` (+66 -47) ➕ `packages/solid/tests/destroy-crash.test.tsx` (+96 -0) ➕ `packages/solid/tests/destroy-race-repro.test.ts` (+66 -0) ➕ `packages/solid/tests/destroy-race.fixture.tsx` (+177 -0) 📝 `packages/web/src/content/docs/components/line-number.mdx` (+8 -1) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>