[PR #717] Fix markdown CodeRenderable illegible in light theme #1513

New issue

Open

opened 2026-03-14 09:40:52 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 09:40:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/717
Author: @NicoDeVeaux
Created: 2/20/2026
Status: 🔄 Open

Base: main ← Head: fix_markdown_light_theme

📝 Commits (4)

13203b2 |
8982925 markdown tests
43f72a3 Merge branch 'main' into fix_markdown_light_theme
55428cc Merge branch 'main' into fix_markdown_light_theme

📊 Changes

2 files changed (+102 additions, -0 deletions)

View changed files

📝 packages/core/src/renderables/Markdown.ts (+12 -0)
📝 packages/core/src/renderables/__tests__/Markdown.test.ts (+90 -0)

📄 Description

I noticed that when in light mode, CodeRenderable text was rendered white on white: it was illegible.

This updates markdown.ts to:

derive code-block fallback colors from markup.raw.block / markup.raw / default
pass those colors into internal CodeRenderable creation

Includes simple unit tests

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/717 **Author:** [@NicoDeVeaux](https://github.com/NicoDeVeaux) **Created:** 2/20/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix_markdown_light_theme` --- ### 📝 Commits (4) - [`13203b2`](https://github.com/anomalyco/opentui/commit/13203b2ca2c900708c596d6ce7398d86d5c7fc51) | - [`8982925`](https://github.com/anomalyco/opentui/commit/8982925678fef5e58f7b9a037b5f5db3af663473) markdown tests - [`43f72a3`](https://github.com/anomalyco/opentui/commit/43f72a3afa7e40ff7c03085b09c22d430df2e4fd) Merge branch 'main' into fix_markdown_light_theme - [`55428cc`](https://github.com/anomalyco/opentui/commit/55428cc107d5ee45216eed32fb9c3eb13391096e) Merge branch 'main' into fix_markdown_light_theme ### 📊 Changes **2 files changed** (+102 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/renderables/Markdown.ts` (+12 -0) 📝 `packages/core/src/renderables/__tests__/Markdown.test.ts` (+90 -0) </details> ### 📄 Description I noticed that when in light mode, CodeRenderable text was rendered white on white: it was illegible. This updates markdown.ts to: * derive code-block fallback colors from markup.raw.block / markup.raw / default * pass those colors into internal CodeRenderable creation Includes simple unit tests --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>