[PR #696] [MERGED] fix(markdown): rebuild table when streaming ends #1503

New issue

Closed

opened 2026-03-14 09:40:20 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 09:40:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/696
Author: @mocksoul
Created: 2/16/2026
Status: ✅ Merged
Merged: 2/17/2026
Merged by: @kommander

Base: main ← Head: fix/streaming-table-rebuild

📝 Commits (4)

e22c07c fix(markdown): rebuild table when streaming ends
eaa22fe test(markdown): add regression test for table finalization after streaming
b275a93 fix(markdown): rebuild table on streaming mode transitions
f7ca70c fix(markdown): rebuild tables on streaming mode changes

📊 Changes

2 files changed (+71 additions, -3 deletions)

View changed files

📝 packages/core/src/renderables/Markdown.ts (+3 -3)
📝 packages/core/src/renderables/__tests__/Markdown.test.ts (+68 -0)

📄 Description

Summary

Last table row is permanently missing after streaming completes
updateBlocks() skips table rebuild when token raw hasn't changed, but the table renderable was created with N-1 rows during streaming (rows.slice(0, -1))
Use clearCache() instead of updateBlocks() on streaming: true→false transition to force full rebuild

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/696 **Author:** [@mocksoul](https://github.com/mocksoul) **Created:** 2/16/2026 **Status:** ✅ Merged **Merged:** 2/17/2026 **Merged by:** [@kommander](https://github.com/kommander) **Base:** `main` ← **Head:** `fix/streaming-table-rebuild` --- ### 📝 Commits (4) - [`e22c07c`](https://github.com/anomalyco/opentui/commit/e22c07c90b06ab1101076b1d3ad6eb25b6179ceb) fix(markdown): rebuild table when streaming ends - [`eaa22fe`](https://github.com/anomalyco/opentui/commit/eaa22fe5e8926eeea9b58419d06792295317252f) test(markdown): add regression test for table finalization after streaming - [`b275a93`](https://github.com/anomalyco/opentui/commit/b275a934c31e7c72c149409f159c8403087450c9) fix(markdown): rebuild table on streaming mode transitions - [`f7ca70c`](https://github.com/anomalyco/opentui/commit/f7ca70c949ffb09d36f9256a8ef757e1c86dcdbe) fix(markdown): rebuild tables on streaming mode changes ### 📊 Changes **2 files changed** (+71 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/renderables/Markdown.ts` (+3 -3) 📝 `packages/core/src/renderables/__tests__/Markdown.test.ts` (+68 -0) </details> ### 📄 Description ## Summary - Last table row is permanently missing after streaming completes - `updateBlocks()` skips table rebuild when token raw hasn't changed, but the table renderable was created with N-1 rows during streaming (`rows.slice(0, -1)`) - Use `clearCache()` instead of `updateBlocks()` on `streaming: true→false` transition to force full rebuild --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>