[PR #623] [MERGED] refactor(terminal): inject env map overrides #1444

New issue

Closed

opened 2026-03-14 09:37:06 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 09:37:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/623
Author: @simonklee
Created: 2/4/2026
Status: ✅ Merged
Merged: 2/4/2026
Merged by: @kommander

Base: main ← Head: refactor-terminal

📝 Commits (1)

46fde84 refactor(terminal): inject env map overrides

📊 Changes

4 files changed (+49 additions, -142 deletions)

View changed files

📝 packages/core/src/zig/build.zig (+0 -1)
📝 packages/core/src/zig/terminal.zig (+14 -4)
📝 packages/core/src/zig/tests/terminal_test.zig (+35 -78)
➖ packages/core/src/zig/tests/test_utils.zig (+0 -59)

📄 Description

allow Terminal to use an injected EnvMap for env lookups
switch terminal tests to EnvMap instead of setenv/unsetenv
remove libc linkage from the Zig test module

Fix #622

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/623 **Author:** [@simonklee](https://github.com/simonklee) **Created:** 2/4/2026 **Status:** ✅ Merged **Merged:** 2/4/2026 **Merged by:** [@kommander](https://github.com/kommander) **Base:** `main` ← **Head:** `refactor-terminal` --- ### 📝 Commits (1) - [`46fde84`](https://github.com/anomalyco/opentui/commit/46fde842303e78a510474e8ee992716f5c67f63c) refactor(terminal): inject env map overrides ### 📊 Changes **4 files changed** (+49 additions, -142 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/zig/build.zig` (+0 -1) 📝 `packages/core/src/zig/terminal.zig` (+14 -4) 📝 `packages/core/src/zig/tests/terminal_test.zig` (+35 -78) ➖ `packages/core/src/zig/tests/test_utils.zig` (+0 -59) </details> ### 📄 Description - allow Terminal to use an injected EnvMap for env lookups - switch terminal tests to EnvMap instead of setenv/unsetenv - remove libc linkage from the Zig test module Fix #622 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>