[PR #558] [MERGED] Feat/select all textarea #1397

New issue

Closed

opened 2026-03-14 09:34:41 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 09:34:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/558
Author: @danolekh
Created: 1/20/2026
Status: ✅ Merged
Merged: 1/26/2026
Merged by: @kommander

Base: main ← Head: feat/select-all-textarea

📝 Commits (8)

ea7420d feat: select all for textareas
1ef5f3d feat: arrow left/right behaviour with selections
c7b96bf handle left-to-right and right-to-left selection differently for move cursor right
d64ac66 chore: add test for selection change on textarea viewport change (#549)
722befc Merge branch 'main' into feat/select-all-textarea
d36cd92 fix(core): selection changes on textarea viewport change (after keyboard selection)
2924e2c update textarea error handling test
33cdf58 refactor: rm redundant onSelectionChanged call, add finishDragging opt

📊 Changes

10 files changed (+134 additions, -34 deletions)

View changed files

📝 packages/core/src/console.test.ts (+5 -5)
📝 packages/core/src/console.ts (+6 -6)
📝 packages/core/src/lib/selection.ts (+5 -5)
📝 packages/core/src/renderables/EditBufferRenderable.ts (+2 -2)
📝 packages/core/src/renderables/ScrollBox.ts (+2 -2)
📝 packages/core/src/renderables/Textarea.ts (+41 -0)
📝 packages/core/src/renderables/__tests__/Textarea.error-handling.test.ts (+1 -1)
📝 packages/core/src/renderables/__tests__/Textarea.selection.test.ts (+45 -0)
📝 packages/core/src/renderer.ts (+21 -12)
📝 packages/core/src/types.ts (+6 -1)

📄 Description

added ability to do select all (cmd+a / ctrl+a behaviour) for textareas #518
browser-like arrow left/right behaviour with selections
added fix for #549

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/558 **Author:** [@danolekh](https://github.com/danolekh) **Created:** 1/20/2026 **Status:** ✅ Merged **Merged:** 1/26/2026 **Merged by:** [@kommander](https://github.com/kommander) **Base:** `main` ← **Head:** `feat/select-all-textarea` --- ### 📝 Commits (8) - [`ea7420d`](https://github.com/anomalyco/opentui/commit/ea7420da7c1ed3098d9dce8a2ba75c8a929a7a1b) feat: select all for textareas - [`1ef5f3d`](https://github.com/anomalyco/opentui/commit/1ef5f3db1cf4548d16c6932365ad74b803c2d1a0) feat: arrow left/right behaviour with selections - [`c7b96bf`](https://github.com/anomalyco/opentui/commit/c7b96bf99becbf430baa9ddb4d6713d658ec834b) handle left-to-right and right-to-left selection differently for move cursor right - [`d64ac66`](https://github.com/anomalyco/opentui/commit/d64ac6696bc39e81218704b0cb0992ed853d7b95) chore: add test for selection change on textarea viewport change (#549) - [`722befc`](https://github.com/anomalyco/opentui/commit/722befc24440e0a592e4ced5b754117785495e0d) Merge branch 'main' into feat/select-all-textarea - [`d36cd92`](https://github.com/anomalyco/opentui/commit/d36cd929cf4f14e4318c91f30b6a15cae3b60d1d) fix(core): selection changes on textarea viewport change (after keyboard selection) - [`2924e2c`](https://github.com/anomalyco/opentui/commit/2924e2ce1663605606c13e87961f7dfa2a8f46a1) update textarea error handling test - [`33cdf58`](https://github.com/anomalyco/opentui/commit/33cdf580bca4217ef66c87bc1574f7ed957cbcc5) refactor: rm redundant onSelectionChanged call, add finishDragging opt ### 📊 Changes **10 files changed** (+134 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/console.test.ts` (+5 -5) 📝 `packages/core/src/console.ts` (+6 -6) 📝 `packages/core/src/lib/selection.ts` (+5 -5) 📝 `packages/core/src/renderables/EditBufferRenderable.ts` (+2 -2) 📝 `packages/core/src/renderables/ScrollBox.ts` (+2 -2) 📝 `packages/core/src/renderables/Textarea.ts` (+41 -0) 📝 `packages/core/src/renderables/__tests__/Textarea.error-handling.test.ts` (+1 -1) 📝 `packages/core/src/renderables/__tests__/Textarea.selection.test.ts` (+45 -0) 📝 `packages/core/src/renderer.ts` (+21 -12) 📝 `packages/core/src/types.ts` (+6 -1) </details> ### 📄 Description - added ability to do select all (cmd+a / ctrl+a behaviour) for textareas #518 - browser-like arrow left/right [behaviour with selections](https://github.com/anomalyco/opentui/issues/518#issuecomment-3765306216) - added fix for #549 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>