[PR #545] [MERGED] refactor(border): add parseBorderStyle function for border style vali… #1387

Closed
opened 2026-03-14 09:34:08 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/545
Author: @msmps
Created: 1/16/2026
Status: Merged
Merged: 1/18/2026
Merged by: @kommander

Base: mainHead: fix/border-seg-fault-20260116174445


📝 Commits (4)

  • 27ec55e refactor(border): add parseBorderStyle function for border style validation
  • 1d7d3d4 Merge branch 'main' into fix/border-seg-fault-20260116174445
  • bc98526 test(border): add regression tests for invalid borderStyle values
  • f130ad4 Merge branch 'main' into fix/border-seg-fault-20260116174445

📊 Changes

5 files changed (+240 additions, -4 deletions)

View changed files

📝 packages/core/src/buffer.ts (+2 -2)
packages/core/src/lib/border.test.ts (+83 -0)
📝 packages/core/src/lib/border.ts (+19 -0)
packages/core/src/renderables/Box.test.ts (+133 -0)
📝 packages/core/src/renderables/Box.ts (+3 -2)

📄 Description

Description

  • fix segfault when invalid borderStyle values are passed to box components
  • added parseBorderStyle() validation that gracefully falls back to "single" with a warning
  • closes #543

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/545 **Author:** [@msmps](https://github.com/msmps) **Created:** 1/16/2026 **Status:** ✅ Merged **Merged:** 1/18/2026 **Merged by:** [@kommander](https://github.com/kommander) **Base:** `main` ← **Head:** `fix/border-seg-fault-20260116174445` --- ### 📝 Commits (4) - [`27ec55e`](https://github.com/anomalyco/opentui/commit/27ec55e809f4f9ef7189dd357facf4e81f97a1c9) refactor(border): add parseBorderStyle function for border style validation - [`1d7d3d4`](https://github.com/anomalyco/opentui/commit/1d7d3d4e030d982680591519463b1913254856e2) Merge branch 'main' into fix/border-seg-fault-20260116174445 - [`bc98526`](https://github.com/anomalyco/opentui/commit/bc98526211214df3cfa821dcc92ce2647fcc38ae) test(border): add regression tests for invalid borderStyle values - [`f130ad4`](https://github.com/anomalyco/opentui/commit/f130ad4b97854aed3178ece80fdd2cf5e1be92ee) Merge branch 'main' into fix/border-seg-fault-20260116174445 ### 📊 Changes **5 files changed** (+240 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/buffer.ts` (+2 -2) ➕ `packages/core/src/lib/border.test.ts` (+83 -0) 📝 `packages/core/src/lib/border.ts` (+19 -0) ➕ `packages/core/src/renderables/Box.test.ts` (+133 -0) 📝 `packages/core/src/renderables/Box.ts` (+3 -2) </details> ### 📄 Description ## Description - fix segfault when invalid `borderStyle` values are passed to box components - added `parseBorderStyle()` validation that gracefully falls back to "single" with a warning - closes #543 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-14 09:34:08 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/opentui#1387
No description provided.