[PR #536] [CLOSED] IGNORE: Critique - Markdown Renderable + Word Diff Highlights #1384

Closed
opened 2026-03-14 09:33:52 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/536
Author: @remorses
Created: 1/16/2026
Status: Closed

Base: mainHead: critique


📝 Commits (10+)

  • ec432ca add word highlights
  • c0ceee1 test: add word highlight tests
  • 85e2afd format
  • 45884fe fix: use Bun.stringWidth for multi-width character support in word highlights
  • ebfc48c fix: correct line counts in example diff hunk header
  • a5a9136 update react example
  • d663823 rename showWordHighlights to disableWordHighlights
  • 117e470 chore: remove verbose comments
  • 1c2e986 refactor: simplify word highlights code
  • 6cc3958 fix: revert unrelated simplifications to split view forEach loops

📊 Changes

4 files changed (+681 additions, -84 deletions)

View changed files

📝 packages/core/src/renderables/Diff.test.ts (+209 -2)
📝 packages/core/src/renderables/Diff.ts (+360 -79)
📝 packages/core/src/renderables/LineNumberRenderable.ts (+103 -1)
📝 packages/react/examples/diff.tsx (+9 -2)

📄 Description

Combines markdown-renderable and word-highlights branches for critique feature.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/536 **Author:** [@remorses](https://github.com/remorses) **Created:** 1/16/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `critique` --- ### 📝 Commits (10+) - [`ec432ca`](https://github.com/anomalyco/opentui/commit/ec432cac1a9527d332685e57476bf1bc8a97eb2a) add word highlights - [`c0ceee1`](https://github.com/anomalyco/opentui/commit/c0ceee17aecec87b2b700d136af9b88bdc330085) test: add word highlight tests - [`85e2afd`](https://github.com/anomalyco/opentui/commit/85e2afd47598537dbfc61307f75a43e97d918e56) format - [`45884fe`](https://github.com/anomalyco/opentui/commit/45884fe3fe62c4bcef341b3a2f539b88f7a694c5) fix: use Bun.stringWidth for multi-width character support in word highlights - [`ebfc48c`](https://github.com/anomalyco/opentui/commit/ebfc48cbaa43898be5f8aab6265cf6a7a964cc28) fix: correct line counts in example diff hunk header - [`a5a9136`](https://github.com/anomalyco/opentui/commit/a5a913680945837295bcb39cc2b018b6d4b17191) update react example - [`d663823`](https://github.com/anomalyco/opentui/commit/d663823ee403f6947e7c01f6addd1d137ed964a2) rename showWordHighlights to disableWordHighlights - [`117e470`](https://github.com/anomalyco/opentui/commit/117e4708abbc9bc38314d1d714d6bbe6414d2bc2) chore: remove verbose comments - [`1c2e986`](https://github.com/anomalyco/opentui/commit/1c2e9860084de5c7ec92ada0663d9b758866e1a5) refactor: simplify word highlights code - [`6cc3958`](https://github.com/anomalyco/opentui/commit/6cc3958a0389f7a6aca22ee3353e4ba02ab3987f) fix: revert unrelated simplifications to split view forEach loops ### 📊 Changes **4 files changed** (+681 additions, -84 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/renderables/Diff.test.ts` (+209 -2) 📝 `packages/core/src/renderables/Diff.ts` (+360 -79) 📝 `packages/core/src/renderables/LineNumberRenderable.ts` (+103 -1) 📝 `packages/react/examples/diff.tsx` (+9 -2) </details> ### 📄 Description Combines markdown-renderable and word-highlights branches for critique feature. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-14 09:33:52 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/opentui#1384
No description provided.