[PR #453] [MERGED] fix: correctly handle enableMouseMovement default value #1325

New issue

Closed

opened 2026-03-14 09:30:38 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 09:30:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/453
Author: @aarongrtech
Created: 12/29/2025
Status: ✅ Merged
Merged: 12/30/2025
Merged by: @kommander

Base: main ← Head: fix/enable-mouse-movement-default

📝 Commits (2)

eec5d3d fix: correctly handle enableMouseMovement default value
3783a82 style: fix prettier formatting in useMouse test

📊 Changes

2 files changed (+89 additions, -1 deletions)

View changed files

📝 packages/core/src/renderer.ts (+1 -1)
➕ packages/core/src/tests/renderer.useMouse.test.ts (+88 -0)

📄 Description

Summary

Fixed bug where useMouse: false was being ignored due to incorrect use of || operator

Problem

In renderer.ts line 513, the code used:

this.enableMouseMovement = config.enableMouseMovement || true

This always evaluates to true because:

true || true = true
false || true = true
undefined || true = true

Solution

Changed to nullish coalescing operator:

this.enableMouseMovement = config.enableMouseMovement ?? true

This correctly handles explicit false:

true ?? true = true
false ?? true = false ← explicit false is now respected!
undefined ?? true = true (default)

Testing

Added unit test at packages/core/src/tests/renderer.useMouse.test.ts that verifies:

useMouse: true enables mouse tracking
useMouse: false disables mouse tracking (NO mouse sequences sent)
Toggling useMouse property updates renderer state correctly

All tests pass.

This fix enables the disable_mouse feature in OpenCode (PR https://github.com/sst/opencode/pull/6329) to work correctly, allowing Linux users with right-click paste terminals (Terminator, PuTTY-style) to use native paste behavior.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/453 **Author:** [@aarongrtech](https://github.com/aarongrtech) **Created:** 12/29/2025 **Status:** ✅ Merged **Merged:** 12/30/2025 **Merged by:** [@kommander](https://github.com/kommander) **Base:** `main` ← **Head:** `fix/enable-mouse-movement-default` --- ### 📝 Commits (2) - [`eec5d3d`](https://github.com/anomalyco/opentui/commit/eec5d3d52849c9367842ee81d9f6b22e58f9f517) fix: correctly handle enableMouseMovement default value - [`3783a82`](https://github.com/anomalyco/opentui/commit/3783a8235afed0e283b88eb3b87581c448d5277b) style: fix prettier formatting in useMouse test ### 📊 Changes **2 files changed** (+89 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/renderer.ts` (+1 -1) ➕ `packages/core/src/tests/renderer.useMouse.test.ts` (+88 -0) </details> ### 📄 Description ## Summary - Fixed bug where `useMouse: false` was being ignored due to incorrect use of `||` operator ## Problem In `renderer.ts` line 513, the code used: ```typescript this.enableMouseMovement = config.enableMouseMovement || true ``` This **always evaluates to true** because: - `true || true` = `true` - `false || true` = `true` - `undefined || true` = `true` ## Solution Changed to nullish coalescing operator: ```typescript this.enableMouseMovement = config.enableMouseMovement ?? true ``` This correctly handles explicit `false`: - `true ?? true` = `true` - `false ?? true` = `false` ← explicit false is now respected! - `undefined ?? true` = `true` (default) ## Testing Added unit test at `packages/core/src/tests/renderer.useMouse.test.ts` that verifies: 1. `useMouse: true` enables mouse tracking 2. `useMouse: false` disables mouse tracking (NO mouse sequences sent) 3. Toggling `useMouse` property updates renderer state correctly All tests pass. ## Related This fix enables the `disable_mouse` feature in OpenCode (PR https://github.com/sst/opencode/pull/6329) to work correctly, allowing Linux users with right-click paste terminals (Terminator, PuTTY-style) to use native paste behavior. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>