[PR #278] [MERGED] fetch layout for all children in layout pass and reduce after, console uses keyhandler to handle kitty keyboard, fix scrollbox loosing initial sticky scroll #1199

New issue

Closed

opened 2026-03-14 09:23:45 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 09:23:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/278
Author: @kommander
Created: 11/7/2025
Status: ✅ Merged
Merged: 11/7/2025
Merged by: @kommander

Base: main ← Head: scroll-clipping

📝 Commits (10+)

5203fff update layout for non-visible children always
c67b348 cover more
33cd0f2 remove obsolete workarounds
6de78bb cover and fix sticky scroll
19d8723 cleanup
2531344 console uses key handler
1e072ca sticky scroll fix
8f5e8ce cleanup
6a1a950 maybe fix flaky test
d7ceaca prettier

📊 Changes

7 files changed (+1071 additions, -180 deletions)

View changed files

📝 packages/core/src/Renderable.ts (+8 -42)
📝 packages/core/src/console.ts (+69 -72)
📝 packages/core/src/renderables/Code.test.ts (+12 -23)
📝 packages/core/src/renderables/Code.ts (+17 -21)
📝 packages/core/src/renderables/ScrollBox.ts (+31 -7)
📝 packages/core/src/tests/renderable.test.ts (+672 -3)
📝 packages/core/src/tests/scrollbox.test.ts (+262 -12)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/278 **Author:** [@kommander](https://github.com/kommander) **Created:** 11/7/2025 **Status:** ✅ Merged **Merged:** 11/7/2025 **Merged by:** [@kommander](https://github.com/kommander) **Base:** `main` ← **Head:** `scroll-clipping` --- ### 📝 Commits (10+) - [`5203fff`](https://github.com/anomalyco/opentui/commit/5203ffff52e2f8eb1dce7ab0d395842cd25bf94a) update layout for non-visible children always - [`c67b348`](https://github.com/anomalyco/opentui/commit/c67b3482bb716d760f2fddb9e989311963959e47) cover more - [`33cd0f2`](https://github.com/anomalyco/opentui/commit/33cd0f2392a9887617866798d5e607efcc881f7e) remove obsolete workarounds - [`6de78bb`](https://github.com/anomalyco/opentui/commit/6de78bb8cfd63cf3d901ce36b7a59e57208e9c8b) cover and fix sticky scroll - [`19d8723`](https://github.com/anomalyco/opentui/commit/19d8723596bb7120f1e96e1e78e2665fe74f2781) cleanup - [`2531344`](https://github.com/anomalyco/opentui/commit/25313442788c8d75b84f1e586119e87a0f35e869) console uses key handler - [`1e072ca`](https://github.com/anomalyco/opentui/commit/1e072ca4bf0988ae71ffe1b182c5babb40364e2b) sticky scroll fix - [`8f5e8ce`](https://github.com/anomalyco/opentui/commit/8f5e8ce76dcf57975682c8cdcf1d3ca4eb26b780) cleanup - [`6a1a950`](https://github.com/anomalyco/opentui/commit/6a1a95077b960b8a2c636fbd7cbb140a38aa0e81) maybe fix flaky test - [`d7ceaca`](https://github.com/anomalyco/opentui/commit/d7ceaca3d00d8cfc4029fb553cf25ab228a7204f) prettier ### 📊 Changes **7 files changed** (+1071 additions, -180 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/Renderable.ts` (+8 -42) 📝 `packages/core/src/console.ts` (+69 -72) 📝 `packages/core/src/renderables/Code.test.ts` (+12 -23) 📝 `packages/core/src/renderables/Code.ts` (+17 -21) 📝 `packages/core/src/renderables/ScrollBox.ts` (+31 -7) 📝 `packages/core/src/tests/renderable.test.ts` (+672 -3) 📝 `packages/core/src/tests/scrollbox.test.ts` (+262 -12) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>