[PR #241] [MERGED] rework placeholder to be fully visual only #1168

New issue

Closed

opened 2026-03-14 09:22:08 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 09:22:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/241
Author: @kommander
Created: 10/28/2025
Status: ✅ Merged
Merged: 10/28/2025
Merged by: @kommander

Base: main ← Head: placeholder-rework

📝 Commits (10+)

4d3f343 placeholder as styled text
bc74103 styled text only
a678bdd leftovers
039ec4c editor demo placeholder
ec4e9cd check demos
2c9d7bc generic text buffer drawing
02c2985 stash
ce92bb8 simplify
4db56b7 cover
d2034c5 test placeholder rendering

📊 Changes

19 files changed (+750 additions, -560 deletions)

View changed files

📝 packages/core/src/edit-buffer.test.ts (+1 -146)
📝 packages/core/src/edit-buffer.ts (+0 -10)
📝 packages/core/src/editor-view.ts (+7 -4)
📝 packages/core/src/examples/editor-demo.ts (+32 -4)
📝 packages/core/src/renderables/EditBufferRenderable.ts (+8 -3)
📝 packages/core/src/renderables/TextBufferRenderable.ts (+6 -2)
📝 packages/core/src/renderables/Textarea.test.ts (+67 -5)
📝 packages/core/src/renderables/Textarea.ts (+22 -20)
📝 packages/core/src/renderables/__snapshots__/Textarea.test.ts.snap (+70 -0)
📝 packages/core/src/zig.ts (+72 -23)
📝 packages/core/src/zig/buffer.zig (+21 -14)
📝 packages/core/src/zig/edit-buffer.zig (+0 -160)
📝 packages/core/src/zig/editor-view.zig (+98 -0)
📝 packages/core/src/zig/lib.zig (+20 -9)
📝 packages/core/src/zig/tests/edit-buffer_test.zig (+0 -146)
📝 packages/core/src/zig/tests/editor-view_test.zig (+275 -0)
📝 packages/core/src/zig/text-buffer-view.zig (+28 -8)
📝 packages/solid/examples/components/ExampleSelector.tsx (+1 -1)
📝 packages/solid/examples/components/textarea-demo.tsx (+22 -5)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/241 **Author:** [@kommander](https://github.com/kommander) **Created:** 10/28/2025 **Status:** ✅ Merged **Merged:** 10/28/2025 **Merged by:** [@kommander](https://github.com/kommander) **Base:** `main` ← **Head:** `placeholder-rework` --- ### 📝 Commits (10+) - [`4d3f343`](https://github.com/anomalyco/opentui/commit/4d3f34344d9b755b134439c2dfddb4465f4af3c7) placeholder as styled text - [`bc74103`](https://github.com/anomalyco/opentui/commit/bc7410375beb939a1067cb99a2f4e094da39bd7a) styled text only - [`a678bdd`](https://github.com/anomalyco/opentui/commit/a678bdd142deec0badee27a67338a80de00e01b5) leftovers - [`039ec4c`](https://github.com/anomalyco/opentui/commit/039ec4ce9108f1807c40b0faa1b819c658ac2de4) editor demo placeholder - [`ec4e9cd`](https://github.com/anomalyco/opentui/commit/ec4e9cd93e65880b12a63483825c1396f25a389e) check demos - [`2c9d7bc`](https://github.com/anomalyco/opentui/commit/2c9d7bc24d0a3bad282cda7ed5bdbb3f210b3f18) generic text buffer drawing - [`02c2985`](https://github.com/anomalyco/opentui/commit/02c2985d070699118ecfddce57d4e32edaac40b9) stash - [`ce92bb8`](https://github.com/anomalyco/opentui/commit/ce92bb887379f0069f4796803471404a17ba5643) simplify - [`4db56b7`](https://github.com/anomalyco/opentui/commit/4db56b77555a671e5c4a8a71173e5f3154623ed8) cover - [`d2034c5`](https://github.com/anomalyco/opentui/commit/d2034c51379bc236228723fc1ed1c69996895b2f) test placeholder rendering ### 📊 Changes **19 files changed** (+750 additions, -560 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/edit-buffer.test.ts` (+1 -146) 📝 `packages/core/src/edit-buffer.ts` (+0 -10) 📝 `packages/core/src/editor-view.ts` (+7 -4) 📝 `packages/core/src/examples/editor-demo.ts` (+32 -4) 📝 `packages/core/src/renderables/EditBufferRenderable.ts` (+8 -3) 📝 `packages/core/src/renderables/TextBufferRenderable.ts` (+6 -2) 📝 `packages/core/src/renderables/Textarea.test.ts` (+67 -5) 📝 `packages/core/src/renderables/Textarea.ts` (+22 -20) 📝 `packages/core/src/renderables/__snapshots__/Textarea.test.ts.snap` (+70 -0) 📝 `packages/core/src/zig.ts` (+72 -23) 📝 `packages/core/src/zig/buffer.zig` (+21 -14) 📝 `packages/core/src/zig/edit-buffer.zig` (+0 -160) 📝 `packages/core/src/zig/editor-view.zig` (+98 -0) 📝 `packages/core/src/zig/lib.zig` (+20 -9) 📝 `packages/core/src/zig/tests/edit-buffer_test.zig` (+0 -146) 📝 `packages/core/src/zig/tests/editor-view_test.zig` (+275 -0) 📝 `packages/core/src/zig/text-buffer-view.zig` (+28 -8) 📝 `packages/solid/examples/components/ExampleSelector.tsx` (+1 -1) 📝 `packages/solid/examples/components/textarea-demo.tsx` (+22 -5) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>