[PR #222] [MERGED] Fix renderable.add with index #1158

New issue

Closed

opened 2026-03-14 09:21:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 09:21:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/222
Author: @kommander
Created: 10/21/2025
Status: ✅ Merged
Merged: 10/21/2025
Merged by: @kommander

Base: main ← Head: repro-solid-list-ordering-issue

📝 Commits (7)

317f069 repro
e14db00 debug
a6816de reproduce in core
30e43ad fix
ab913a9 cleanup
9fb841e more test coverage
e033bec do not expect warnings anymore

📊 Changes

5 files changed (+828 additions, -26 deletions)

View changed files

📝 packages/core/src/Renderable.ts (+26 -26)
📝 packages/core/src/tests/renderable.snapshot.test.ts (+452 -0)
📝 packages/solid/examples/components/ExampleSelector.tsx (+9 -0)
➕ packages/solid/examples/components/autocomplete-demo.tsx (+270 -0)
📝 packages/solid/tests/control-flow.test.tsx (+71 -0)

📄 Description

Now delegating to and using similar logic as insertBefore

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/222 **Author:** [@kommander](https://github.com/kommander) **Created:** 10/21/2025 **Status:** ✅ Merged **Merged:** 10/21/2025 **Merged by:** [@kommander](https://github.com/kommander) **Base:** `main` ← **Head:** `repro-solid-list-ordering-issue` --- ### 📝 Commits (7) - [`317f069`](https://github.com/anomalyco/opentui/commit/317f069f2d7a3184256687d659b96c664c7bb4cc) repro - [`e14db00`](https://github.com/anomalyco/opentui/commit/e14db0052c3cacd80fb8224a2c180977c369186d) debug - [`a6816de`](https://github.com/anomalyco/opentui/commit/a6816de3c8b4bbc65e6aaf0c478a9f40ca899b22) reproduce in core - [`30e43ad`](https://github.com/anomalyco/opentui/commit/30e43adfb90ade16a0e20ef77e28118b2ad4a091) fix - [`ab913a9`](https://github.com/anomalyco/opentui/commit/ab913a92d3c30321cce0a20e803e00e2a2687c7f) cleanup - [`9fb841e`](https://github.com/anomalyco/opentui/commit/9fb841e62e723b49e6d46a2d67e6040a89f1db99) more test coverage - [`e033bec`](https://github.com/anomalyco/opentui/commit/e033bec9ff24851fa9b042f85b56ccf3221bb048) do not expect warnings anymore ### 📊 Changes **5 files changed** (+828 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/Renderable.ts` (+26 -26) 📝 `packages/core/src/tests/renderable.snapshot.test.ts` (+452 -0) 📝 `packages/solid/examples/components/ExampleSelector.tsx` (+9 -0) ➕ `packages/solid/examples/components/autocomplete-demo.tsx` (+270 -0) 📝 `packages/solid/tests/control-flow.test.tsx` (+71 -0) </details> ### 📄 Description Now delegating to and using similar logic as `insertBefore` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>