[PR #189] [MERGED] Fix(core): Yoga error due to incomplete removal of child node #1137

Closed
opened 2026-03-14 09:20:30 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/189
Author: @Adictya
Created: 9/30/2025
Status: Merged
Merged: 9/30/2025
Merged by: @kommander

Base: mainHead: core-orphan-child-fix


📝 Commits (2)

  • bc0a67e fix(core): Cleanup forceLayoutUpdateFor and newChildren arrays on removal
  • d68048a text cover with private access as crash is not reproducible in test env somehow

📊 Changes

3 files changed (+69 additions, -10 deletions)

View changed files

📝 packages/core/src/Renderable.ts (+12 -0)
📝 packages/core/src/renderer.ts (+13 -9)
📝 packages/core/src/tests/renderable.test.ts (+44 -1)

📄 Description

No description provided


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/189 **Author:** [@Adictya](https://github.com/Adictya) **Created:** 9/30/2025 **Status:** ✅ Merged **Merged:** 9/30/2025 **Merged by:** [@kommander](https://github.com/kommander) **Base:** `main` ← **Head:** `core-orphan-child-fix` --- ### 📝 Commits (2) - [`bc0a67e`](https://github.com/anomalyco/opentui/commit/bc0a67e514a8aac317860aa0f6495b953a2edda1) fix(core): Cleanup forceLayoutUpdateFor and newChildren arrays on removal - [`d68048a`](https://github.com/anomalyco/opentui/commit/d68048abac82322a3a5a063b7b0eb106832af559) text cover with private access as crash is not reproducible in test env somehow ### 📊 Changes **3 files changed** (+69 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/Renderable.ts` (+12 -0) 📝 `packages/core/src/renderer.ts` (+13 -9) 📝 `packages/core/src/tests/renderable.test.ts` (+44 -1) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-14 09:20:30 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/opentui#1137
No description provided.