[PR #173] [MERGED] Fix(solid): Solid insert sibling order issue #1123

Closed
opened 2026-03-14 09:19:42 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/173
Author: @Adictya
Created: 9/22/2025
Status: Merged
Merged: 9/22/2025
Merged by: @Adictya

Base: mainHead: solid-issues-fixup-sep-22


📝 Commits (2)

  • a492355 fix(solid): incorrect get sibbling call
  • 4129cc7 chore(solid): format

📊 Changes

3 files changed (+79 additions, -3 deletions)

View changed files

📝 packages/solid/src/reconciler.ts (+5 -1)
📝 packages/solid/src/renderer/universal.js (+1 -1)
📝 packages/solid/tests/control-flow.test.tsx (+73 -1)

📄 Description

No description provided


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/173 **Author:** [@Adictya](https://github.com/Adictya) **Created:** 9/22/2025 **Status:** ✅ Merged **Merged:** 9/22/2025 **Merged by:** [@Adictya](https://github.com/Adictya) **Base:** `main` ← **Head:** `solid-issues-fixup-sep-22` --- ### 📝 Commits (2) - [`a492355`](https://github.com/anomalyco/opentui/commit/a4923558dfc6724a8b2e0b4d6be12a6f9890ab4f) fix(solid): incorrect get sibbling call - [`4129cc7`](https://github.com/anomalyco/opentui/commit/4129cc7ddececc54fa81a1bf540ba8eee630ff1e) chore(solid): format ### 📊 Changes **3 files changed** (+79 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/solid/src/reconciler.ts` (+5 -1) 📝 `packages/solid/src/renderer/universal.js` (+1 -1) 📝 `packages/solid/tests/control-flow.test.tsx` (+73 -1) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-14 09:19:42 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/opentui#1123
No description provided.