[PR #147] [MERGED] Fix solid renderable lifecycle issues #1104

New issue

Closed

opened 2026-03-14 09:18:37 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 09:18:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/147
Author: @fezproof
Created: 9/8/2025
Status: ✅ Merged
Merged: 9/8/2025
Merged by: @kommander

Base: main ← Head: fix-solid-renderable-lifecycle-issues

📝 Commits (4)

5e1b899 fix: destroy removed nodes on next tick
bef4091 chore: cleanup
d6cb350 Fix order of destruction to ensure children are removed first
0f81e6f Add comment to clarify change

📊 Changes

7 files changed (+168 additions, -7 deletions)

View changed files

📝 packages/core/src/Renderable.ts (+2 -1)
➕ packages/solid/examples/repro-empty-styled-text.tsx (+45 -0)
➕ packages/solid/examples/repro-filter-list.tsx (+40 -0)
➕ packages/solid/examples/repro-onSubmit.tsx (+70 -0)
📝 packages/solid/package.json (+0 -4)
📝 packages/solid/src/elements/text-node.ts (+6 -1)
📝 packages/solid/src/reconciler.ts (+5 -1)

📄 Description

Fixes issue with solid reusing old nodes in list arrangement. This should also make things more performant.
Fixes issue where parents where destroying themselves instead of their children first, leaving dangling children.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/147 **Author:** [@fezproof](https://github.com/fezproof) **Created:** 9/8/2025 **Status:** ✅ Merged **Merged:** 9/8/2025 **Merged by:** [@kommander](https://github.com/kommander) **Base:** `main` ← **Head:** `fix-solid-renderable-lifecycle-issues` --- ### 📝 Commits (4) - [`5e1b899`](https://github.com/anomalyco/opentui/commit/5e1b899b7048aa2099c85f285022eca79f7f8c38) fix: destroy removed nodes on next tick - [`bef4091`](https://github.com/anomalyco/opentui/commit/bef409100f833d64514b3004f82966d75a24a366) chore: cleanup - [`d6cb350`](https://github.com/anomalyco/opentui/commit/d6cb3506bfc68c70a10a1bc2bc0e85a351a338fd) Fix order of destruction to ensure children are removed first - [`0f81e6f`](https://github.com/anomalyco/opentui/commit/0f81e6f2c29c2827d345d75b4c1e99bcd3de900c) Add comment to clarify change ### 📊 Changes **7 files changed** (+168 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/Renderable.ts` (+2 -1) ➕ `packages/solid/examples/repro-empty-styled-text.tsx` (+45 -0) ➕ `packages/solid/examples/repro-filter-list.tsx` (+40 -0) ➕ `packages/solid/examples/repro-onSubmit.tsx` (+70 -0) 📝 `packages/solid/package.json` (+0 -4) 📝 `packages/solid/src/elements/text-node.ts` (+6 -1) 📝 `packages/solid/src/reconciler.ts` (+5 -1) </details> ### 📄 Description Fixes issue with solid reusing old nodes in list arrangement. This should also make things more performant. Fixes issue where parents where destroying themselves instead of their children first, leaving dangling children. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>