[PR #38] [MERGED] Add tab-select renderable event listeners #1019

New issue

Closed

opened 2026-03-14 09:14:02 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 09:14:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/38
Author: @Adictya
Created: 8/18/2025
Status: ✅ Merged
Merged: 8/18/2025
Merged by: @kommander

Base: main ← Head: solid-opentui-demo

📝 Commits (3)

89f04a9 feat: add tab select apis
6d9b8d6 fix build script
735bf56 fix change to ghost node

📊 Changes

4 files changed (+137 additions, -14 deletions)

View changed files

📝 packages/solid/examples/components/ExampleSelector.tsx (+9 -0)
➕ packages/solid/examples/components/tab-select-demo.tsx (+80 -0)
📝 packages/solid/src/elements/index.ts (+7 -1)
📝 packages/solid/src/reconciler.ts (+41 -13)

📄 Description

There is a bug in current solid implementation with no parent elements. This naively fixes it

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/38 **Author:** [@Adictya](https://github.com/Adictya) **Created:** 8/18/2025 **Status:** ✅ Merged **Merged:** 8/18/2025 **Merged by:** [@kommander](https://github.com/kommander) **Base:** `main` ← **Head:** `solid-opentui-demo` --- ### 📝 Commits (3) - [`89f04a9`](https://github.com/anomalyco/opentui/commit/89f04a9f0b508465cbb4d995721b0cda53f25d3e) feat: add tab select apis - [`6d9b8d6`](https://github.com/anomalyco/opentui/commit/6d9b8d604895debc2d5376c7ea7871bc0b1a91cc) fix build script - [`735bf56`](https://github.com/anomalyco/opentui/commit/735bf565c74b5192dcf55935f1a18cd9255f6769) fix change to ghost node ### 📊 Changes **4 files changed** (+137 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `packages/solid/examples/components/ExampleSelector.tsx` (+9 -0) ➕ `packages/solid/examples/components/tab-select-demo.tsx` (+80 -0) 📝 `packages/solid/src/elements/index.ts` (+7 -1) 📝 `packages/solid/src/reconciler.ts` (+41 -13) </details> ### 📄 Description There is a bug in current solid implementation with no parent <text> elements. This naively fixes it --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>