[PR #20] [MERGED] destroyRecursively + warn if id exists + refactor cleanup #1002

New issue

Closed

opened 2026-03-14 09:13:13 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 09:13:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/20
Author: @kommander
Created: 8/15/2025
Status: ✅ Merged
Merged: 8/15/2025
Merged by: @kommander

Base: main ← Head: fix-root-renderable

📝 Commits (4)

7953dbb remove obsolete refactoring leftover
bf3d661 destroy recursive + warn if renderable id exists
7057db2 todo
2d55d14 fix demos

📊 Changes

6 files changed (+51 additions, -122 deletions)

View changed files

📝 src/Renderable.ts (+12 -25)
📝 src/examples/ascii-font-selection-demo.ts (+18 -46)
📝 src/examples/split-mode-demo.ts (+1 -1)
📝 src/examples/text-selection-demo.ts (+15 -48)
📝 src/renderables/FrameBuffer.ts (+5 -1)
📝 src/renderables/index.ts (+0 -1)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/20 **Author:** [@kommander](https://github.com/kommander) **Created:** 8/15/2025 **Status:** ✅ Merged **Merged:** 8/15/2025 **Merged by:** [@kommander](https://github.com/kommander) **Base:** `main` ← **Head:** `fix-root-renderable` --- ### 📝 Commits (4) - [`7953dbb`](https://github.com/anomalyco/opentui/commit/7953dbb8d27cd3e934fc27e110afb596749c3483) remove obsolete refactoring leftover - [`bf3d661`](https://github.com/anomalyco/opentui/commit/bf3d661ffd8ae6d695c9b571189cd01625b3520c) destroy recursive + warn if renderable id exists - [`7057db2`](https://github.com/anomalyco/opentui/commit/7057db2da5fa9075b9b72ed69a81129927ef6fba) todo - [`2d55d14`](https://github.com/anomalyco/opentui/commit/2d55d147e50c80bb6004fc73a568942acec5b514) fix demos ### 📊 Changes **6 files changed** (+51 additions, -122 deletions) <details> <summary>View changed files</summary> 📝 `src/Renderable.ts` (+12 -25) 📝 `src/examples/ascii-font-selection-demo.ts` (+18 -46) 📝 `src/examples/split-mode-demo.ts` (+1 -1) 📝 `src/examples/text-selection-demo.ts` (+15 -48) 📝 `src/renderables/FrameBuffer.ts` (+5 -1) 📝 `src/renderables/index.ts` (+0 -1) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>