[PR #34] [MERGED] "Fix" admin email not working correctly #93

New issue

Closed

opened 2026-02-25 23:39:53 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:39:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/HaschekSolutions/opentrashmail/pull/34
Author: @manfromafar
Created: 11/29/2021
Status: ✅ Merged
Merged: 11/30/2021
Merged by: @geek-at

Base: master ← Head: master

📝 Commits (2)

3d072d2 Update api.php
dace8a0 Update api.php

📊 Changes

1 file changed (+7 additions, -2 deletions)

View changed files

📝 web/api.php (+7 -2)

📄 Description

Admin email setting in config was not working as intended.
Applied quick hack to get setting working again.
Culprit appears that the $email is overwritten when the check for empty var happens.
This causes the admin check to fail no matter what.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/HaschekSolutions/opentrashmail/pull/34 **Author:** [@manfromafar](https://github.com/manfromafar) **Created:** 11/29/2021 **Status:** ✅ Merged **Merged:** 11/30/2021 **Merged by:** [@geek-at](https://github.com/geek-at) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`3d072d2`](https://github.com/HaschekSolutions/opentrashmail/commit/3d072d22c55966f399a3fcc99a9bf990c1e94ea4) Update api.php - [`dace8a0`](https://github.com/HaschekSolutions/opentrashmail/commit/dace8a0df06d4b097b4e716ae204b87c2de9c7a8) Update api.php ### 📊 Changes **1 file changed** (+7 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `web/api.php` (+7 -2) </details> ### 📄 Description Admin email setting in config was not working as intended. Applied quick hack to get setting working again. Culprit appears that the $email is overwritten when the check for empty var happens. This causes the admin check to fail no matter what. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>