mirror of
https://github.com/HaschekSolutions/opentrashmail.git
synced 2026-04-25 06:35:55 +03:00
[GH-ISSUE #7] Consider using moment.js for date formatting #5
Labels
No labels
bug
enhancement
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/opentrashmail#5
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @poblabs on GitHub (Oct 3, 2019).
Original GitHub issue: https://github.com/HaschekSolutions/opentrashmail/issues/7
I'm in the US, and the date format opentrashmail is using doesn't make sense to me at first glance since we use Month/Day/Year format.
moment.js would be great for this type of date formatting to allow others to use the format they're used to.
This could be a quick add by using an option inside config.ini to define the string format, then have PHP grab the string format when it loads
$settings, and adding that to the$oarray. JavaScript can then grab that string format and format the epoch accordingly.I have a working example and can submit a PR if you'd like?
Edit: here's the working example:
github.com/poblabs/opentrashmail@f82d50b56e@geek-at commented on GitHub (Oct 6, 2019):
sure, send that sweet PR