starred/onthespot

Fork 0

mirror of https://github.com/casualsnek/onthespot.git synced 2026-04-26 20:45:56 +03:00

[GH-ISSUE #88] [Feature] Store album art as a separate file in the album folder #60

New issue

Open

opened 2026-03-04 12:28:33 +03:00 by kerem · 5 comments

kerem commented

2026-03-04 12:28:33 +03:00

Owner

Originally created by @artofsound on GitHub (Aug 21, 2023).
Original GitHub issue: https://github.com/casualsnek/onthespot/issues/88

I want an option to store the album art as a additional file in the same folder, where the downloaded track is stored.
Saving the album art should be done, after downloading all of the album tracks. Doesn't need to be after every single track.

Probably something like "cover.jpg" should do the trick, but maybe you could add a filename option, so users could change it on their behalf.

Originally created by @artofsound on GitHub (Aug 21, 2023). Original GitHub issue: https://github.com/casualsnek/onthespot/issues/88 I want an option to store the album art as a additional file in the same folder, where the downloaded track is stored. Saving the album art should be done, after downloading all of the album tracks. Doesn't need to be after every single track. Probably something like "cover.jpg" should do the trick, but maybe you could add a filename option, so users could change it on their behalf.

kerem added the

enhancement

label

2026-03-04 12:28:33 +03:00

kerem commented

2026-03-04 12:28:34 +03:00

Author

Owner

@NiciTheNici commented on GitHub (Oct 31, 2023):

bump, this is insanely useful for rockbox users

@NiciTheNici commented on GitHub (Oct 31, 2023): bump, this is insanely useful for rockbox users

kerem commented

2026-03-04 12:28:34 +03:00

Author

Owner

@NiciTheNici commented on GitHub (Oct 31, 2023):

I managed to get this working on my fork. @casualsnek do you think this even needs an option or should it just default to saving the cover art as cover.png all the time like I did in my fork?

https://github.com/NiciTheNici/onthespot/tree/save_cover_as_file

@NiciTheNici commented on GitHub (Oct 31, 2023): I managed to get this working on my fork. @casualsnek do you think this even needs an option or should it just default to saving the cover art as `cover.png` all the time like I did in my fork? https://github.com/NiciTheNici/onthespot/tree/save_cover_as_file

kerem commented

2026-03-04 12:28:34 +03:00

Author

Owner

@casualsnek commented on GitHub (Oct 31, 2023):

I managed to get this working on my fork. @casualsnek do you think this even needs an option or should it just default to saving the cover art as cover.png all the time like I did in my fork?

https://github.com/NiciTheNici/onthespot/tree/save_cover_as_file

This being a default behavior won't be too bad as i have seen a lot of media player use it instead of embedded one or using embedded ones only if cover.png is missing !

Good to know you got it working, normally i wold have suggested you to make a PR, but since i am rewriting onthespot all PR and non critical Issue resolution are paused right now. I may make this a default behavior but configurable using the config files in the rewrite.

@casualsnek commented on GitHub (Oct 31, 2023): > I managed to get this working on my fork. @casualsnek do you think this even needs an option or should it just default to saving the cover art as `cover.png` all the time like I did in my fork? > > https://github.com/NiciTheNici/onthespot/tree/save_cover_as_file This being a default behavior won't be too bad as i have seen a lot of media player use it instead of embedded one or using embedded ones only if cover.png is missing ! Good to know you got it working, normally i wold have suggested you to make a PR, but since i am rewriting onthespot all PR and non critical Issue resolution are paused right now. I may make this a default behavior but configurable using the config files in the rewrite.

kerem commented

2026-03-04 12:28:34 +03:00

Author

Owner

@artofsound commented on GitHub (Oct 31, 2023):

I also have a version that works on my fork, even with a settings option you can tick. I used .jpg tho, because that's what Spotify gives you.
If the file already exists, it skips it.

https://github.com/artofsound/onthespot/tree/cover_image

@artofsound commented on GitHub (Oct 31, 2023): I also have a version that works on my fork, even with a settings option you can tick. I used `.jpg` tho, because that's what Spotify gives you. If the file already exists, it skips it. https://github.com/artofsound/onthespot/tree/cover_image ![Screenshot 2023-10-31 093232](https://github.com/casualsnek/onthespot/assets/39335345/48a2a67f-d2dc-41b0-8567-723513b3a8b6)

kerem commented

2026-03-04 12:28:34 +03:00

Author

Owner

@NiciTheNici commented on GitHub (Oct 31, 2023):

I used .jpg tho, because that's what Spotify gives you.

Ah I just used png because that's what the method set_music_thumbnail used a few lines above my text. Not unnecessarily converting between formats is probably more efficient...

If the file already exists, it skips it.

Same!

I may make this a default behavior but configurable using the config files in the rewrite.

Sounds perfect! Thanks!

@NiciTheNici commented on GitHub (Oct 31, 2023): >I used .jpg tho, because that's what Spotify gives you. Ah I just used png because that's what the method [`set_music_thumbnail`](https://github.com/casualsnek/onthespot/commit/ae1ecbee71ef510d3d1a3d4ffe3edbb54306fdd0) used a few lines above my text. Not unnecessarily converting between formats is probably more efficient... > If the file already exists, it skips it. Same! > I may make this a default behavior but configurable using the config files in the rewrite. Sounds perfect! Thanks!