starred/odin-maelstrom-cms

Fork 0

mirror of https://github.com/maelstrom-cms/odin.git synced 2026-04-25 08:16:03 +03:00

[GH-ISSUE #32] Timezone and x-axis of uptime monitor #19

New issue

Closed

opened 2026-02-27 09:12:37 +03:00 by kerem · 4 comments

kerem commented

2026-02-27 09:12:37 +03:00

Owner

Originally created by @martin-ro on GitHub (Sep 4, 2020).
Original GitHub issue: https://github.com/maelstrom-cms/odin/issues/32

Hi,

I think the timezone shouldn't be hard-coded in app/Console/Kernel.php but using the config from config/app.pp.

protected function scheduleTimezone()
    {
        return 'Europe/London';
    }

--->

protected function scheduleTimezone()
    {
        return config('app.timezone');
    }

so we can set the timezone in .env.

Would you accept a PR?

Another thing I noticed is that the timescale for the uptime monitor goes from right-to-left. Is this intentional? Normally timescales go ltr.

Originally created by @martin-ro on GitHub (Sep 4, 2020). Original GitHub issue: https://github.com/maelstrom-cms/odin/issues/32 Hi, I think the timezone shouldn't be hard-coded in `app/Console/Kernel.php` but using the config from `config/app.pp`. ``` protected function scheduleTimezone() { return 'Europe/London'; } ``` ---> ``` protected function scheduleTimezone() { return config('app.timezone'); } ``` so we can set the timezone in `.env`. Would you accept a PR? Another thing I noticed is that the timescale for the uptime monitor goes from right-to-left. Is this intentional? Normally timescales go ltr.

kerem

2026-02-27 09:12:37 +03:00

closed this issue
added the
enhancement

help wanted
labels

kerem commented

2026-02-27 09:12:38 +03:00

Author

Owner

@OwenMelbz commented on GitHub (Sep 13, 2020):

Hi,

Yeah we'd accept a PR to configure the time zone from the env as long as it defaults to London :)

I'm not sure what you mean about the right to left thing sorry?

Thanks

@OwenMelbz commented on GitHub (Sep 13, 2020): Hi, Yeah we'd accept a PR to configure the time zone from the env as long as it defaults to London :) I'm not sure what you mean about the right to left thing sorry? Thanks

kerem commented

2026-02-27 09:12:38 +03:00

Author

Owner

@dsturm commented on GitHub (Oct 20, 2020):

Hey @OwenMelbz,

about the "right-to-left" thing: I think what @martin-ro means is that normally a time scale would draw from oldest (left) to newest (right) entries. Currently it is the other way around for the Response Time chart having the latest data on the left.

@dsturm commented on GitHub (Oct 20, 2020): Hey @OwenMelbz, about the "right-to-left" thing: I think what @martin-ro means is that *normally* a time scale would draw from oldest (left) to newest (right) entries. Currently it is the other way around for the Response Time chart having the latest data on the left.

kerem commented

2026-02-27 09:12:38 +03:00

Author

Owner

@dsturm commented on GitHub (Oct 20, 2020):

... and towards the time zone configuration:

I think, since the core class already uses the config key app.schedule_timezone and app.timezone as fallback, it should be safe to remove the method scheduleTimezone from app/Console/Kernel.php.

@dsturm commented on GitHub (Oct 20, 2020): ... and towards the time zone configuration: I think, since the [core class already uses the config key `app.schedule_timezone` and `app.timezone` as fallback](https://github.com/laravel/framework/blob/2cd2877fb003d395b5b292a363b917e31cf60200/src/Illuminate/Foundation/Console/Kernel.php#L171), it should be safe to remove the method `scheduleTimezone` from `app/Console/Kernel.php`.

kerem commented

2026-02-27 09:12:38 +03:00

Author

Owner

@OwenMelbz commented on GitHub (Oct 20, 2020):

Thanks for the help 👍

Have merged and closed :)

@OwenMelbz commented on GitHub (Oct 20, 2020): Thanks for the help 👍 Have merged and closed :)

kerem referenced this issue

2026-02-27 09:12:44 +03:00

[PR #19] [MERGED] Bump symfony/http-foundation from 4.3.5 to 4.4.1 #46