mirror of
https://github.com/maelstrom-cms/odin.git
synced 2026-04-26 00:36:05 +03:00
[GH-ISSUE #21] Maybe send a notification if robots.txt file doesn’t exist? #14
Labels
No labels
bug
enhancement
help wanted
pull-request
question
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/odin-maelstrom-cms#14
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @andrewminion-luminfire on GitHub (Jan 30, 2020).
Original GitHub issue: https://github.com/maelstrom-cms/odin/issues/21
We’re using this internally to monitor some client sites and noticed that those without a robots.txt result in failed horizon jobs:
GuzzleHttp\Exception\ClientException: Client error: `GET https://clientname.com/robots.txt` resulted in a `404 Not Found` response:I would think the ideal handling is to catch that exception and send a notification that the file doesn’t exist. For now I can just disable robots monitoring on those sites.
@OwenMelbz commented on GitHub (Jan 30, 2020):
Do you definitely have robots.txt monitoring turned off in the settings??
@andrewminion-luminfire commented on GitHub (Jan 30, 2020):
No, robots.txt monitor was turned on in the settings for those sites, but I didn’t realize they don’t have an existing robots.txt file.
@OwenMelbz commented on GitHub (Jan 31, 2020):
Okay, so to confirm - is there a problem?
If you do not have a
robots.txtto monitor, then you should keep the setting turned off, this is only needed if you have arobots.txtto track@andrewminion-luminfire commented on GitHub (Jan 31, 2020):
When you put it that way …no, there’s not really a problem 😊
On Jan 30, 2020, 6:41 PM -0600, Owen Melbourne notifications@github.com, wrote: