[PR #276] Change graph score offset thresholds to match values from monitor scorer #834

New issue

Open

opened 2026-03-13 15:14:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 15:14:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/abh/ntppool/pull/276
Author: @daerSeebaer
Created: 1/14/2026
Status: 🔄 Open

Base: main ← Head: monv4-colored-graphs

📝 Commits (1)

d57edad change graph score offset thresholds to match values from monitor scorer

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 client/src/utils/dom-utils.ts (+3 -2)

📄 Description

The threshold values for point deduction and minimum points to be included in the pool have been changed. Goal of this PR is to match the color coding of the offset charts on the pool management page to the values used in the production monitoring system:

< 25ms: Full points (green)
25-100ms: Point deduction, but still viable for the pool (orange)
>100ms: Point deduction, server score will settle below 10 points and the server will not be included in the pool (red)

Full reasoning can be found in my earlier PR https://github.com/abh/ntppool/pull/249 which is superseded by this one.

Part of https://github.com/abh/ntppool/issues/251

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/abh/ntppool/pull/276 **Author:** [@daerSeebaer](https://github.com/daerSeebaer) **Created:** 1/14/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `monv4-colored-graphs` --- ### 📝 Commits (1) - [`d57edad`](https://github.com/abh/ntppool/commit/d57edad90228f2d02191c9cd74744734d481b1cf) change graph score offset thresholds to match values from monitor scorer ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `client/src/utils/dom-utils.ts` (+3 -2) </details> ### 📄 Description The threshold values for point deduction and minimum points to be included in the pool have been changed. Goal of this PR is to match the color coding of the offset charts on the pool management page to the values used in the production monitoring system: - < 25ms: Full points (green) - 25-100ms: Point deduction, but still viable for the pool (orange) - \>100ms: Point deduction, server score will settle below 10 points and the server will not be included in the pool (red) Full reasoning can be found in my earlier PR https://github.com/abh/ntppool/pull/249 which is superseded by this one. Part of https://github.com/abh/ntppool/issues/251 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>