[PR #249] [CLOSED] Make server page graph coloring consistent with scoring #815

New issue

Closed

opened 2026-03-13 15:14:10 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 15:14:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/abh/ntppool/pull/249
Author: @daerSeebaer
Created: 12/29/2024
Status: ❌ Closed

Base: main ← Head: score-colored-graphs

📝 Commits (1)

2aee9ac graphs: Make coloring consistent with scoring

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 docs/shared/static/js/graphs.server.js (+2 -2)

📄 Description

Why was this changed

The scoring system currently has four "ranges" depending on the time offset between the monitored server and the monitor:

<75ms : The server is considered "good" and receives one point in the scoring, improving its reputation
75 - 250ms: The server is still considered as viable, but not as good. In this range, a sliding scale is applied, granting a lesser score for a higher offset. At 250ms offset, 0 points are granted.
>250ms: The same sliding scale is still applied, but returns negative values, resulting in a loss of reputation for the server. The higher the offset, the higher the loss. At 750ms, the scale reaches -2 points.
>750ms: The monitor returns -2 points
>3000ms: The monitor returns -4 points. Additionally, the server reputation is capped at -20 points, removing it from the pool immediately if it had been above 10 points before.

The colouring scheme in the graphs of the management sites had three "ranges":

<50ms : Green
50 - 100ms : Orange
>100ms : Red

My suggestion is to unify both systems. This increases transparency for pool operators and users. The graph already is the direct feedback what the monitoring system thinks about the server in terms of current reputation. Adding in the colouring scheme adds the layer of how the reputation is currently changing.

To keep the current traffic light scheme with red-yellow-green, I've decided to map everything in the negative point range to "red" since this indicates that the server will lose points and drop out of the NTP Pool eventually. The yellow range is adjusted to the slow gain range where the server is generally considered viable, but gets a penalty for inaccuracy. Indicating this with yellow should also give the server operator the feedback that the accuracy of the server should be improved. The range where the server gets the full score is indicated in green.

What was changed

I simply edited the threshold that determine the colors.

Impact

Expected advantages have been outlined above.
Since this is a purely visual change, I do not expect any negative side effects.

I look forward to constructive feedback and reviews.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/abh/ntppool/pull/249 **Author:** [@daerSeebaer](https://github.com/daerSeebaer) **Created:** 12/29/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `score-colored-graphs` --- ### 📝 Commits (1) - [`2aee9ac`](https://github.com/abh/ntppool/commit/2aee9ac69456acec30973524498f45c422234861) graphs: Make coloring consistent with scoring ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `docs/shared/static/js/graphs.server.js` (+2 -2) </details> ### 📄 Description ## Why was this changed The [scoring system](https://github.com/ntppool/monitor/blob/29c316960e7027eb4cd02ef20fee6db5eaf17b4e/scorer/statusscore/statusscore.go#L67) currently has four "ranges" depending on the time offset between the monitored server and the monitor: - <75ms : The server is considered "good" and receives one point in the scoring, improving its reputation - 75 - 250ms: The server is still considered as viable, but not as good. In this range, a sliding scale is applied, granting a lesser score for a higher offset. At 250ms offset, 0 points are granted. - \>250ms: The same sliding scale is still applied, but returns negative values, resulting in a loss of reputation for the server. The higher the offset, the higher the loss. At 750ms, the scale reaches -2 points. - \>750ms: The monitor returns -2 points - \>3000ms: The monitor returns -4 points. Additionally, the server reputation is capped at -20 points, removing it from the pool immediately if it had been above 10 points before. ![grafik](https://github.com/user-attachments/assets/a3c465d6-5b84-488c-b1b1-b936385f084a) The colouring scheme in the graphs of the management sites had three "ranges": - <50ms : Green - 50 - 100ms : Orange - \>100ms : Red My suggestion is to unify both systems. This increases transparency for pool operators and users. The graph already is the direct feedback what the monitoring system thinks about the server in terms of current reputation. Adding in the colouring scheme adds the layer of how the reputation is currently changing. To keep the current traffic light scheme with red-yellow-green, I've decided to map everything in the negative point range to "red" since this indicates that the server will lose points and drop out of the NTP Pool eventually. The yellow range is adjusted to the slow gain range where the server is generally considered viable, but gets a penalty for inaccuracy. Indicating this with yellow should also give the server operator the feedback that the accuracy of the server should be improved. The range where the server gets the full score is indicated in green. ## What was changed I simply edited the threshold that determine the colors. ## Impact Expected advantages have been outlined above. Since this is a purely visual change, I do not expect any negative side effects. I look forward to constructive feedback and reviews. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>