[GH-ISSUE #216] Graphs with minutes use 12 hour format #356

New issue

Open

opened 2026-03-01 17:25:25 +03:00 by kerem · 1 comment

kerem commented

2026-03-01 17:25:25 +03:00

Owner

Originally created by @MarcelWaldvogel on GitHub (Jan 31, 2022).
Original GitHub issue: https://github.com/abh/ntppool/issues/216

Originally assigned to: @abh, @Copilot on GitHub.

Expected behavior

All times on the graphs are given in 24 hour format, based on UTC.

Actual behavior

When minutes are displayed, the hours are shown in 12 hour format (without AM/PM). Everything else is correct.

How to reproduce

Log in to the test system
Add a new host to the pool between 13:00 and 22:00 UTC ("monitoring only" status is also OK)
Wait 1-2 hours
Look at the graph in the "account" view (see screenshot below). The graph shows hours-only marks (HH format) correctly (24 hour format), but the HH:MM formatted times between that use 12-hour format, resulting in e.g. the sequence "8:45", "21", "9:15", ….

I have not verified whether this also occurs in the production system and/or the individual host view. (The screenshot is from the "account" view in the test system.)

BTW: It would be a bonus for the sequence afterwards to not read "20:45", "21", "21:15", but "20:45", "21", "21:15" instead (notice the "21:00"), for consistency.

Originally created by @MarcelWaldvogel on GitHub (Jan 31, 2022). Original GitHub issue: https://github.com/abh/ntppool/issues/216 Originally assigned to: @abh, @Copilot on GitHub. ## Expected behavior All times on the graphs are given in 24 hour format, based on UTC. ## Actual behavior When minutes are displayed, the hours are shown in 12 hour format (without AM/PM). Everything else is correct. ## How to reproduce 1. Log in to the test system 2. Add a new host to the pool between 13:00 and 22:00 UTC ("monitoring only" status is also OK) 3. Wait 1-2 hours 4. Look at the graph in the "account" view (see screenshot below). The graph shows hours-only marks (`HH` format) correctly (24 hour format), but the `HH:MM` formatted times between that use 12-hour format, resulting in e.g. the sequence "8:45", "21", "9:15", …. I have not verified whether this also occurs in the production system and/or the individual host view. (The screenshot is from the "account" view in the test system.) BTW: It would be a bonus for the sequence afterwards to not read "20:45", "21", "21:15", but "20:45", "21", "21:15" instead (notice the "21:00"), for consistency. ![grafik](https://user-images.githubusercontent.com/3014737/151783305-76889b9f-5ef7-4aca-a408-d62ca8a8a22c.png)

kerem commented

2026-03-01 17:25:26 +03:00

Author

Owner

@abh commented on GitHub (Jun 4, 2025):

this would be somewhere in docs/shared/static/js/graphs.js or docs/shared/static/js/graphs.server.js.

The graphs are built with (an older version of) D3.js and ... it's hard for me to work on. Maybe the LLM can help us?

@abh commented on GitHub (Jun 4, 2025): this would be somewhere in `docs/shared/static/js/graphs.js` or `docs/shared/static/js/graphs.server.js`. The graphs are built with (an older version of) D3.js and ... it's hard for me to work on. Maybe the LLM can help us?