[PR #56] [CLOSED] PR 56: build(deps-dev): bump electron from 31.2.1 to 33.0.1 #230

New issue

Closed

opened 2026-03-13 17:42:37 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 17:42:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Aetherinox/ntfy-desktop/pull/56
Author: @dependabot[bot]
Created: 10/17/2024
Status: ❌ Closed

Base: main ← Head: dependabot/npm_and_yarn/electron-33.0.1

📝 Commits (1)

e339d07 build(deps-dev): bump electron from 31.2.1 to 33.0.1

📊 Changes

2 files changed (+5 additions, -6 deletions)

View changed files

📝 package-lock.json (+4 -5)
📝 package.json (+1 -1)

📄 Description

Bumps electron from 31.2.1 to 33.0.1.

Release notes

Sourced from electron's releases.

electron v33.0.1

Release Notes for v33.0.1

Other Changes

Updated Chromium to 130.0.6723.59. #44271

electron v33.0.0

Release Notes for 33.0.0

Stack Upgrades

Chromium 130.0.6723.44

New in 130

New in 129

Node 20.18.0

Node 20.18.0 blog post

Node 20.17.0 blog post

V8 13.0

Breaking Changes

Deprecated usage of textured BrowserWindow type option on macOS. #43133

Custom protocol URLs that use Windows file paths will no longer work correctly with the deprecated protocol.registerFileProtocol and the baseURLForDataURL property on BrowserWindow.loadURL, WebContents.loadURL, and <webview>.loadURL. #43977

Features

Additions

Added a handler, app.setClientCertRequestPasswordHandler(handler), to help unlock cryptographic devices when a PIN is needed. #41205

Added error event in utility process to support diagnostic reports on V8 fatal errors. #43997

Added View.setBorderRadius(radius) for customizing the border radius of views—with compatibility for WebContentsView. #42320

Added Linux support for the Windows Control Overlay API. #41769 (Also in 30, 31, 32)

Added support for the macOS system picker in desktopCapturer and setDisplayMediaRequestHandler. #43680 (Also in 32)

Added DownloadItem.getCurrentBytesPerSecond(), DownloadItem.getPercentComplete(), DownloadItem.getEndTime(). #42805 (Also in 30, 31, 32)

Added a new property prefersReducedTransparency to nativeTheme, which indicates whether the user has chosen to reduce OS-level transparency via system accessibility settings. #42862 (Also in 30, 31, 32)

Added support for responding to auth requests initiated from utility process via app#login event. #42631 (Also in 32)

Improvements

Extended navigationHistory API with 2 new functions for better history management. #42014

Ensured that the sender-id hint is set when creating desktop notifications on DBus. #43949 (Also in 31, 32)

Aligned failure pathway in File System Access API with upstream when attempting to open a file or directory in a blocked path. #42561 (Also in 30, 31, 32)

Enabled zstd compression in net http requests. #43150 (Also in 31, 32)

Expose systemPreferences to utilityProcess. #42203 (Also in 30, 31, 32)

Fixes

Fixed a build failure when the enable_plugins build flag is false. #44025

Fixed mouse cursor turning into loading spinner when starting utility process on Windows. #43731

... (truncated)

Changelog

Sourced from electron's changelog.

Breaking Changes

Breaking changes will be documented here, and deprecation warnings added to JS code where possible, at least one major version before the change is made.

Types of Breaking Changes

This document uses the following convention to categorize breaking changes:

API Changed: An API was changed in such a way that code that has not been updated is guaranteed to throw an exception.

Behavior Changed: The behavior of Electron has changed, but not in such a way that an exception will necessarily be thrown.

Default Changed: Code depending on the old default may break, not necessarily throwing an exception. The old behavior can be restored by explicitly specifying the value.

Deprecated: An API was marked as deprecated. The API will continue to function, but will emit a deprecation warning, and will be removed in a future release.

Removed: An API or feature was removed, and is no longer supported by Electron.

Planned Breaking API Changes (33.0)

Behavior Changed: frame properties may retrieve detached WebFrameMain instances or none at all

APIs which provide access to a WebFrameMain instance may return an instance with frame.detached set to true, or possibly return null.

When a frame performs a cross-origin navigation, it enters into a detached state in which it's no longer attached to the page. In this state, it may be running unload handlers prior to being deleted. In the event of an IPC sent during this state, frame.detached will be set to true with the frame being destroyed shortly thereafter.

When receiving an event, it's important to access WebFrameMain properties immediately upon being received. Otherwise, it's not guaranteed to point to the same webpage as when received. To avoid misaligned expectations, Electron will return null in the case of late access where the webpage has changed.
ipcMain.on('unload-event', (event) => {
  event.senderFrame; // ✅ accessed immediately
});
ipcMain.on('unload-event', async (event) => {

await crossOriginNavigationPromise;

event.senderFrame; // ❌ returns null due to late access

});
Behavior Changed: custom protocol URL handling on Windows

Due to changes made in Chromium to support Non-Special Scheme URLs, custom protocol URLs that use Windows file paths will no longer work correctly with the deprecated protocol.registerFileProtocol and the baseURLForDataURL property on BrowserWindow.loadURL, WebContents.loadURL, and <webview>.loadURL. protocol.handle will also not work with these types of URLs but this is not a change since it has always worked that way.
// No longer works
</tr></table> 

... (truncated)

Commits

11c2b61 chore: bump chromium to 130.0.6723.59 (33-x-y) (#44271)
6b458c7 fix: -Wunsafe-buffer-usage warnings in TaskbarHost::SetThumbarButtons() (#44260)
77324ff build: update devcontainer sha (#44245)
63d1d9c fix: SCContentSharingPicker crash in iframes (#44228)
dd5bce1 docs: update timelines for E34 (#44225)
258a4a7 fix: -Wunsafe-buffer-usage warning in ChunkedDataPipeReadableStream (#44223)
f269ca1 test: fix visibility-state-spec.ts flaky test (#44199)
7887395 fix: -Wunsafe-buffer-usage warnings when read()ing and write()ing integers (#...
9011532 fix: clang variable configuration in generated node headers (#44200)
afce3ce docs: clarify interplay between utility process events (#44203)
Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note

Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Aetherinox/ntfy-desktop/pull/56 **Author:** [@dependabot[bot]](https://github.com/apps/dependabot) **Created:** 10/17/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `dependabot/npm_and_yarn/electron-33.0.1` --- ### 📝 Commits (1) - [`e339d07`](https://github.com/Aetherinox/ntfy-desktop/commit/e339d07c7af31b4b7c2da2c65800b53cd7b28bf8) build(deps-dev): bump electron from 31.2.1 to 33.0.1 ### 📊 Changes **2 files changed** (+5 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `package-lock.json` (+4 -5) 📝 `package.json` (+1 -1) </details> ### 📄 Description Bumps [electron](https://github.com/electron/electron) from 31.2.1 to 33.0.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/electron/electron/releases">electron's releases</a>.</em></p> <blockquote> <h2>electron v33.0.1</h2> <h1>Release Notes for v33.0.1</h1> <h2>Other Changes</h2> <ul> <li>Updated Chromium to 130.0.6723.59. <a href="https://redirect.github.com/electron/electron/pull/44271">#44271</a></li> </ul> <h2>electron v33.0.0</h2> <h1>Release Notes for 33.0.0</h1> <h2>Stack Upgrades</h2> <ul> <li>Chromium <code>130.0.6723.44</code> <ul> <li><a href="https://developer.chrome.com/blog/new-in-chrome-130/">New in 130</a></li> <li><a href="https://developer.chrome.com/blog/new-in-chrome-129/">New in 129</a></li> </ul> </li> <li>Node <code>20.18.0</code> <ul> <li><a href="https://nodejs.org/en/blog/release/v20.18.0/">Node 20.18.0 blog post</a></li> <li><a href="https://nodejs.org/en/blog/release/v20.17.0/">Node 20.17.0 blog post</a></li> </ul> </li> <li>V8 <code>13.0</code></li> </ul> <h2>Breaking Changes</h2> <ul> <li>Deprecated usage of <code>textured</code> BrowserWindow <code>type</code> option on macOS. <a href="https://redirect.github.com/electron/electron/pull/43133">#43133</a></li> <li>Custom protocol URLs that use Windows file paths will no longer work correctly with the deprecated <code>protocol.registerFileProtocol</code> and the <code>baseURLForDataURL</code> property on <code>BrowserWindow.loadURL</code>, <code>WebContents.loadURL</code>, and <code><webview>.loadURL</code>. <a href="https://redirect.github.com/electron/electron/pull/43977">#43977</a></li> </ul> <h2>Features</h2> <h3>Additions</h3> <ul> <li>Added a handler, <code>app.setClientCertRequestPasswordHandler(handler)</code>, to help unlock cryptographic devices when a PIN is needed. <a href="https://redirect.github.com/electron/electron/pull/41205">#41205</a></li> <li>Added error event in utility process to support diagnostic reports on V8 fatal errors. <a href="https://redirect.github.com/electron/electron/pull/43997">#43997</a></li> <li>Added <code>View.setBorderRadius(radius)</code> for customizing the border radius of views—with compatibility for <code>WebContentsView</code>. <a href="https://redirect.github.com/electron/electron/pull/42320">#42320</a></li> <li>Added Linux support for the Windows Control Overlay API. <a href="https://redirect.github.com/electron/electron/pull/41769">#41769</a> (Also in <a href="https://redirect.github.com/electron/electron/pull/42683">30</a>, <a href="https://redirect.github.com/electron/electron/pull/42682">31</a>, <a href="https://redirect.github.com/electron/electron/pull/42681">32</a>)</li> <li>Added support for the macOS system picker in <code>desktopCapturer</code> and <code>setDisplayMediaRequestHandler</code>. <a href="https://redirect.github.com/electron/electron/pull/43680">#43680</a> (Also in <a href="https://redirect.github.com/electron/electron/pull/43679">32</a>)</li> <li>Added <code>DownloadItem.getCurrentBytesPerSecond()</code>, <code>DownloadItem.getPercentComplete()</code>, <code>DownloadItem.getEndTime()</code>. <a href="https://redirect.github.com/electron/electron/pull/42805">#42805</a> (Also in <a href="https://redirect.github.com/electron/electron/pull/42914">30</a>, <a href="https://redirect.github.com/electron/electron/pull/42915">31</a>, <a href="https://redirect.github.com/electron/electron/pull/42913">32</a>)</li> <li>Added a new property <code>prefersReducedTransparency</code> to <code>nativeTheme</code>, which indicates whether the user has chosen to reduce OS-level transparency via system accessibility settings. <a href="https://redirect.github.com/electron/electron/pull/42862">#42862</a> (Also in <a href="https://redirect.github.com/electron/electron/pull/43138">30</a>, <a href="https://redirect.github.com/electron/electron/pull/43137">31</a>, <a href="https://redirect.github.com/electron/electron/pull/43024">32</a>)</li> <li>Added support for responding to auth requests initiated from utility process via <code>app#login</code> event. <a href="https://redirect.github.com/electron/electron/pull/42631">#42631</a> (Also in <a href="https://redirect.github.com/electron/electron/pull/43317">32</a>)</li> </ul> <h3>Improvements</h3> <ul> <li>Extended <code>navigationHistory</code> API with 2 new functions for better history management. <a href="https://redirect.github.com/electron/electron/pull/42014">#42014</a></li> <li>Ensured that the <code>sender-id</code> hint is set when creating desktop notifications on DBus. <a href="https://redirect.github.com/electron/electron/pull/43949">#43949</a> (Also in <a href="https://redirect.github.com/electron/electron/pull/43951">31</a>, <a href="https://redirect.github.com/electron/electron/pull/43950">32</a>)</li> <li>Aligned failure pathway in File System Access API with upstream when attempting to open a file or directory in a blocked path. <a href="https://redirect.github.com/electron/electron/pull/42561">#42561</a> (Also in <a href="https://redirect.github.com/electron/electron/pull/43162">30</a>, <a href="https://redirect.github.com/electron/electron/pull/42994">31</a>, <a href="https://redirect.github.com/electron/electron/pull/42993">32</a>)</li> <li>Enabled zstd compression in net http requests. <a href="https://redirect.github.com/electron/electron/pull/43150">#43150</a> (Also in <a href="https://redirect.github.com/electron/electron/pull/43301">31</a>, <a href="https://redirect.github.com/electron/electron/pull/43300">32</a>)</li> <li>Expose <code>systemPreferences</code> to <code>utilityProcess</code>. <a href="https://redirect.github.com/electron/electron/pull/42203">#42203</a> (Also in <a href="https://redirect.github.com/electron/electron/pull/42600">30</a>, <a href="https://redirect.github.com/electron/electron/pull/42598">31</a>, <a href="https://redirect.github.com/electron/electron/pull/42599">32</a>)</li> </ul> <h2>Fixes</h2> <ul> <li>Fixed a build failure when the <code>enable_plugins</code> build flag is false. <a href="https://redirect.github.com/electron/electron/pull/44025">#44025</a></li> <li>Fixed mouse cursor turning into loading spinner when starting utility process on Windows. <a href="https://redirect.github.com/electron/electron/pull/43731">#43731</a></li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/electron/electron/blob/main/docs/breaking-changes.md">electron's changelog</a>.</em></p> <blockquote> <h1>Breaking Changes</h1> <p>Breaking changes will be documented here, and deprecation warnings added to JS code where possible, at least <a href="https://github.com/electron/electron/blob/main/docs/tutorial/electron-versioning.md#semver">one major version</a> before the change is made.</p> <h3>Types of Breaking Changes</h3> <p>This document uses the following convention to categorize breaking changes:</p> <ul> <li><strong>API Changed:</strong> An API was changed in such a way that code that has not been updated is guaranteed to throw an exception.</li> <li><strong>Behavior Changed:</strong> The behavior of Electron has changed, but not in such a way that an exception will necessarily be thrown.</li> <li><strong>Default Changed:</strong> Code depending on the old default may break, not necessarily throwing an exception. The old behavior can be restored by explicitly specifying the value.</li> <li><strong>Deprecated:</strong> An API was marked as deprecated. The API will continue to function, but will emit a deprecation warning, and will be removed in a future release.</li> <li><strong>Removed:</strong> An API or feature was removed, and is no longer supported by Electron.</li> </ul> <h2>Planned Breaking API Changes (33.0)</h2> <h3>Behavior Changed: frame properties may retrieve detached WebFrameMain instances or none at all</h3> <p>APIs which provide access to a <code>WebFrameMain</code> instance may return an instance with <code>frame.detached</code> set to <code>true</code>, or possibly return <code>null</code>.</p> <p>When a frame performs a cross-origin navigation, it enters into a detached state in which it's no longer attached to the page. In this state, it may be running <a href="https://developer.mozilla.org/en-US/docs/Web/API/Window/unload_event">unload</a> handlers prior to being deleted. In the event of an IPC sent during this state, <code>frame.detached</code> will be set to <code>true</code> with the frame being destroyed shortly thereafter.</p> <p>When receiving an event, it's important to access WebFrameMain properties immediately upon being received. Otherwise, it's not guaranteed to point to the same webpage as when received. To avoid misaligned expectations, Electron will return <code>null</code> in the case of late access where the webpage has changed.</p> <pre lang="ts"><code>ipcMain.on('unload-event', (event) => { event.senderFrame; // ✅ accessed immediately }); <p>ipcMain.on('unload-event', async (event) => {<br /> await crossOriginNavigationPromise;<br /> event.senderFrame; // ❌ returns <code>null</code> due to late access<br /> });<br /> </code></pre></p> <h3>Behavior Changed: custom protocol URL handling on Windows</h3> <p>Due to changes made in Chromium to support <a href="http://bit.ly/url-non-special">Non-Special Scheme URLs</a>, custom protocol URLs that use Windows file paths will no longer work correctly with the deprecated <code>protocol.registerFileProtocol</code> and the <code>baseURLForDataURL</code> property on <code>BrowserWindow.loadURL</code>, <code>WebContents.loadURL</code>, and <code><webview>.loadURL</code>. <code>protocol.handle</code> will also not work with these types of URLs but this is not a change since it has always worked that way.</p> <pre lang="js"><code>// No longer works </tr></table> </code></pre> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/electron/electron/commit/11c2b610116524e92dc8c0aa2d4c2873b2735814"><code>11c2b61</code></a> chore: bump chromium to 130.0.6723.59 (33-x-y) (<a href="https://redirect.github.com/electron/electron/issues/44271">#44271</a>)</li> <li><a href="https://github.com/electron/electron/commit/6b458c78b0962941411d26b2db46daec5d6cdba9"><code>6b458c7</code></a> fix: -Wunsafe-buffer-usage warnings in TaskbarHost::SetThumbarButtons() (<a href="https://redirect.github.com/electron/electron/issues/44260">#44260</a>)</li> <li><a href="https://github.com/electron/electron/commit/77324ff514416f672cba2f1956a496ad202486b0"><code>77324ff</code></a> build: update devcontainer sha (<a href="https://redirect.github.com/electron/electron/issues/44245">#44245</a>)</li> <li><a href="https://github.com/electron/electron/commit/63d1d9cb6554548238bcbfb754115db2f27557dd"><code>63d1d9c</code></a> fix: SCContentSharingPicker crash in iframes (<a href="https://redirect.github.com/electron/electron/issues/44228">#44228</a>)</li> <li><a href="https://github.com/electron/electron/commit/dd5bce17cb3d95e631e1c70cecdca7ce32807070"><code>dd5bce1</code></a> docs: update timelines for E34 (<a href="https://redirect.github.com/electron/electron/issues/44225">#44225</a>)</li> <li><a href="https://github.com/electron/electron/commit/258a4a76cf3978414f5c6049626fc35ab7ec900f"><code>258a4a7</code></a> fix: -Wunsafe-buffer-usage warning in ChunkedDataPipeReadableStream (<a href="https://redirect.github.com/electron/electron/issues/44223">#44223</a>)</li> <li><a href="https://github.com/electron/electron/commit/f269ca1d9331c8cccc55f54ffebcb29c36aa8cdd"><code>f269ca1</code></a> test: fix visibility-state-spec.ts flaky test (<a href="https://redirect.github.com/electron/electron/issues/44199">#44199</a>)</li> <li><a href="https://github.com/electron/electron/commit/7887395e92a99bc585a39cbab0c939af3686f309"><code>7887395</code></a> fix: -Wunsafe-buffer-usage warnings when read()ing and write()ing integers (#...</li> <li><a href="https://github.com/electron/electron/commit/9011532b2e58c6bde4ef75ad790dc9be7f588f94"><code>9011532</code></a> fix: clang variable configuration in generated node headers (<a href="https://redirect.github.com/electron/electron/issues/44200">#44200</a>)</li> <li><a href="https://github.com/electron/electron/commit/afce3ce7c78aa962f75301e6e45603063599d477"><code>afce3ce</code></a> docs: clarify interplay between utility process events (<a href="https://redirect.github.com/electron/electron/issues/44203">#44203</a>)</li> <li>Additional commits viewable in <a href="https://github.com/electron/electron/compare/v31.2.1...v33.0.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=electron&package-manager=npm_and_yarn&previous-version=31.2.1&new-version=33.0.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> > **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>