mirror of
https://github.com/Aetherinox/ntfy-desktop.git
synced 2026-04-25 06:55:54 +03:00
[PR #144] PR 144: [BUG]: Fix bHidden updates and general context, allow some interaction with notification and force one app-instance #148
Labels
No labels
Build › MacOS
Status › Need Info
Status › No Action
Status › Released
Type › Bug
Type › Feature
Type › Feature
Type › Roadmap
pull-request
❔ Question
📰 Progress Report
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ntfy-desktop#148
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Aetherinox/ntfy-desktop/pull/144
Author: @n3m3s7s
Created: 12/3/2025
Status: 🔄 Open
Base:
main← Head:main📝 Commits (1)
ee7448bFix bHidden updates and general context, allow some interaction with notification and force one app-instance📊 Changes
2 files changed (+1815 additions, -1745 deletions)
View changed files
📝
src/index.js(+1677 -1607)📝
src/package.json(+138 -138)📄 Description
Fix bHidden updates and general context
sometimes the "bHidden" variable - which is a global variable tracking the main window visibility status - is not correctly updated, especially when reacting on some events such as "minimize window", "minimize to tray" and/or when changing the visibility on user interacton from different locations;
now the variable should be properly updated and reactive, and the Windows visibility should change instantly;
Allow some interaction with notification
Now when a notification is showed after a successfull polling request, that notification has been modified to be able to:
since a NTFY message can have a "click" attribute (which should be an absolute URL), clicking on the notification will open the default browser (and not in electron); this only when the "click" variable exist in the payload and is not null or an empty string;
clicking on the notification will try to show (or wake up) the main window (as expected);
Force only one app instance at any time
Since most users are not tech-guys they usually open the application several times, and this causes a lot of issues;
Yes, this could be mitigate with the option "Always quit app" but is not very convenient, especially if You want every user to receive notifications even when they are not using the PC;
so basically now - since is possibile via Electron - the workflow will take care to allow only one instance of Ntfy-Desktop;
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.