[PR #524] [MERGED] Fix connectivity test when editing domains (again) #534

New issue

Closed

opened 2026-02-26 10:32:05 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 10:32:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nsupdate-info/nsupdate.info/pull/524
Author: @PhrozenByte
Created: 4/18/2023
Status: ✅ Merged
Merged: 4/18/2023
Merged by: @ThomasWaldmann

Base: master ← Head: bugfix/connectivity-test-2

📝 Commits (1)

74a960d Fix connectivity test when editing domains (again)

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/nsupdate/main/forms.py (+1 -1)

📄 Description

Follow-up to #492 to fix #523

Same procedure as last year:

UNTESTED CHANGES (again)! I still have never worked with Django, nor do I run my own nsupdate.info instance. Unfortunately I still don't have enough time to set things up to test the changes I made. The changes are rather trivial, so I'm rather confident that they should do the trick (I've said that before... I was wrong... Maybe I'm right now? 🙈), but they need testing nevertheless. I believe that providing this patch is better than nothing, even if this PR is considered unmergeable - it at least gives some hints about what the issue might be with ~~#479~~ #523.

I assume that Django is going to reject the invalid nameserver_ip later anyway, so we can simply skip check_domain() if no (valid) nameserver_ip is given. But I truly don't know, checking would require me to set up a local dev environment, something I unfortunately just don't have enough time for 😞 Providing a patch is better than nothing, even though this patch probably isn't really worth the work...

No addition to the changelog since it's fixing an unreleased previous change.

Fixes #523

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nsupdate-info/nsupdate.info/pull/524 **Author:** [@PhrozenByte](https://github.com/PhrozenByte) **Created:** 4/18/2023 **Status:** ✅ Merged **Merged:** 4/18/2023 **Merged by:** [@ThomasWaldmann](https://github.com/ThomasWaldmann) **Base:** `master` ← **Head:** `bugfix/connectivity-test-2` --- ### 📝 Commits (1) - [`74a960d`](https://github.com/nsupdate-info/nsupdate.info/commit/74a960d706e7d72f51251da60d7f5ba6c214c4f7) Fix connectivity test when editing domains (again) ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/nsupdate/main/forms.py` (+1 -1) </details> ### 📄 Description Follow-up to #492 to fix #523 Same procedure as last year: > **UNTESTED CHANGES** <ins>(again)</ins>**!** I <ins>still</ins> have never worked with Django, nor do I run my own nsupdate.info instance. Unfortunately I <ins>still</ins> don't have enough time to set things up to test the changes I made. The changes are rather trivial, so I'm rather confident that they should do the trick <ins>(I've said that before... I was wrong... Maybe I'm right now? :see_no_evil:)</ins>, but they need testing nevertheless. I believe that providing this patch is better than nothing, even if this PR is considered unmergeable - it at least gives some hints about what the issue might be with <del>#479</del> <ins>#523</ins>. I **assume** that Django is going to reject the invalid `nameserver_ip` later anyway, so we can simply skip `check_domain()` if no (valid) `nameserver_ip` is given. But I truly don't know, checking would require me to set up a local dev environment, something I unfortunately just don't have enough time for :disappointed: Providing a patch is better than nothing, even though this patch probably isn't really worth the work... No addition to the changelog since it's fixing an unreleased previous change. Fixes #523 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>