[PR #492] [MERGED] Fix connectivity test when editing domains #516

New issue

Closed

opened 2026-02-26 10:31:57 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 10:31:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nsupdate-info/nsupdate.info/pull/492
Author: @PhrozenByte
Created: 6/5/2022
Status: ✅ Merged
Merged: 4/12/2023
Merged by: @ThomasWaldmann

Base: master ← Head: bugfix/connectivity-test

📝 Commits (1)

c3721f4 Fix connectivity test when editing domains

📊 Changes

3 files changed (+8 additions, -4 deletions)

View changed files

📝 CHANGES.rst (+1 -0)
📝 src/nsupdate/main/dnstools.py (+6 -3)
📝 src/nsupdate/main/forms.py (+1 -1)

📄 Description

UNTESTED CHANGES! I've never worked with Django, nor do I run my own nsupdate.info instance. Unfortunately I don't have enough time to set things up to test the changes I made. The changes are rather trivial, so I'm rather confident that they should do the trick, but they need testing nevertheless. I believe that providing this patch is better than nothing, even if this PR is considered unmergeable - it at least gives some hints about what the issue might be with #479.

Fixes #479

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nsupdate-info/nsupdate.info/pull/492 **Author:** [@PhrozenByte](https://github.com/PhrozenByte) **Created:** 6/5/2022 **Status:** ✅ Merged **Merged:** 4/12/2023 **Merged by:** [@ThomasWaldmann](https://github.com/ThomasWaldmann) **Base:** `master` ← **Head:** `bugfix/connectivity-test` --- ### 📝 Commits (1) - [`c3721f4`](https://github.com/nsupdate-info/nsupdate.info/commit/c3721f40f556e31585e398f7aea26c14f72ac9aa) Fix connectivity test when editing domains ### 📊 Changes **3 files changed** (+8 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `CHANGES.rst` (+1 -0) 📝 `src/nsupdate/main/dnstools.py` (+6 -3) 📝 `src/nsupdate/main/forms.py` (+1 -1) </details> ### 📄 Description **UNTESTED CHANGES!** I've never worked with Django, nor do I run my own nsupdate.info instance. Unfortunately I don't have enough time to set things up to test the changes I made. The changes are rather trivial, so I'm rather confident that they should do the trick, but they need testing nevertheless. I believe that providing this patch is better than nothing, even if this PR is considered unmergeable - it at least gives some hints about what the issue might be with #479. Fixes #479 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>