[PR #454] [MERGED] fix Domain.generate_ns_secret() storing bytes object into Domain.nameserver_update_secret #514

New issue

Closed

opened 2026-02-26 10:31:57 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 10:31:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nsupdate-info/nsupdate.info/pull/454
Author: @brice-gros
Created: 1/21/2020
Status: ✅ Merged
Merged: 1/23/2020
Merged by: @ThomasWaldmann

Base: master ← Head: alternative/convert-python-bytes-to-string-before-charfield-assignement

📝 Commits (1)

a8a6a20 fix Domain.generate_ns_secret() storing bytes object into Domain.nameserver_update_secret instead of a string

📊 Changes

2 files changed (+2 additions, -1 deletions)

View changed files

📝 CHANGES.rst (+1 -0)
📝 src/nsupdate/main/models.py (+1 -1)

📄 Description

Relates to #453

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nsupdate-info/nsupdate.info/pull/454 **Author:** [@brice-gros](https://github.com/brice-gros) **Created:** 1/21/2020 **Status:** ✅ Merged **Merged:** 1/23/2020 **Merged by:** [@ThomasWaldmann](https://github.com/ThomasWaldmann) **Base:** `master` ← **Head:** `alternative/convert-python-bytes-to-string-before-charfield-assignement` --- ### 📝 Commits (1) - [`a8a6a20`](https://github.com/nsupdate-info/nsupdate.info/commit/a8a6a208b1eb8b49077af9b5d38154c1ada990e7) fix Domain.generate_ns_secret() storing bytes object into Domain.nameserver_update_secret instead of a string ### 📊 Changes **2 files changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `CHANGES.rst` (+1 -0) 📝 `src/nsupdate/main/models.py` (+1 -1) </details> ### 📄 Description Relates to #453 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>