[PR #233] [MERGED] use www.BASEDOMAIN for WWW_HOST, prepare for #224 #418

Closed
opened 2026-02-26 10:31:25 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nsupdate-info/nsupdate.info/pull/233
Author: @ThomasWaldmann
Created: 12/28/2015
Status: Merged
Merged: 12/28/2015
Merged by: @ThomasWaldmann

Base: masterHead: publicsuffix


📝 Commits (1)

  • 1b3db1e use www.BASEDOMAIN for WWW_HOST, prepare for #224

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 nsupdate/settings/prod.py (+3 -1)

📄 Description

we must not work without www. because if we get the basedomain on publicsuffix.org list,
the browser will not set cookies any more for that. if we use a host below, it will work normally.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nsupdate-info/nsupdate.info/pull/233 **Author:** [@ThomasWaldmann](https://github.com/ThomasWaldmann) **Created:** 12/28/2015 **Status:** ✅ Merged **Merged:** 12/28/2015 **Merged by:** [@ThomasWaldmann](https://github.com/ThomasWaldmann) **Base:** `master` ← **Head:** `publicsuffix` --- ### 📝 Commits (1) - [`1b3db1e`](https://github.com/nsupdate-info/nsupdate.info/commit/1b3db1e1244db00616a51c28e2470ee5f615f8ef) use www.BASEDOMAIN for WWW_HOST, prepare for #224 ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `nsupdate/settings/prod.py` (+3 -1) </details> ### 📄 Description we must not work without www. because if we get the basedomain on publicsuffix.org list, the browser will not set cookies any more for that. if we use a host below, it will work normally. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 10:31:25 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/nsupdate.info-nsupdate-info#418
No description provided.