[GH-ISSUE #509] rev_lookup(1.1.1.1) fails #371

New issue

Closed

opened 2026-02-26 10:31:08 +03:00 by kerem · 3 comments

kerem commented

2026-02-26 10:31:08 +03:00

Owner

Originally created by @ThomasWaldmann on GitHub (Mar 18, 2023).
Original GitHub issue: https://github.com/nsupdate-info/nsupdate.info/issues/509

Originally assigned to: @ThomasWaldmann on GitHub.

on github ci:

self = <nsupdate.main._tests.test_dnstools.TestReverseLookup object at 0x7fc9031955b0>
    def test_rev_lookup_v4(self):
        name, ip = 'one.one.one.one', '1.1.1.1'
>       assert rev_lookup(ip) == name
E       AssertionError: assert '' == 'one.one.one.one'
E         - one.one.one.one

.tox/py38/lib/python3.8/site-packages/nsupdate/main/_tests/test_dnstools.py:123: AssertionError

Originally created by @ThomasWaldmann on GitHub (Mar 18, 2023). Original GitHub issue: https://github.com/nsupdate-info/nsupdate.info/issues/509 Originally assigned to: @ThomasWaldmann on GitHub. on github ci: ``` self = <nsupdate.main._tests.test_dnstools.TestReverseLookup object at 0x7fc9031955b0> def test_rev_lookup_v4(self): name, ip = 'one.one.one.one', '1.1.1.1' > assert rev_lookup(ip) == name E AssertionError: assert '' == 'one.one.one.one' E - one.one.one.one .tox/py38/lib/python3.8/site-packages/nsupdate/main/_tests/test_dnstools.py:123: AssertionError ```

kerem

2026-02-26 10:31:08 +03:00

closed this issue
added the
bug
label

kerem commented

2026-02-26 10:31:09 +03:00

Author

Owner

@ThomasWaldmann commented on GitHub (Mar 18, 2023):

sometimes also the v6 one fails:

_____________________ TestReverseLookup.test_rev_lookup_v6 _____________________
self = <nsupdate.main._tests.test_dnstools.TestReverseLookup object at 0x7f1d22cd69b0>
    def test_rev_lookup_v6(self):
        name, ip = 'one.one.one.one', '2606:4700:4700::1111'
>       assert rev_lookup(ip) == name
E       AssertionError: assert '' == 'one.one.one.one'
E         - one.one.one.one

@ThomasWaldmann commented on GitHub (Mar 18, 2023): sometimes also the v6 one fails: ``` _____________________ TestReverseLookup.test_rev_lookup_v6 _____________________ self = <nsupdate.main._tests.test_dnstools.TestReverseLookup object at 0x7f1d22cd69b0> def test_rev_lookup_v6(self): name, ip = 'one.one.one.one', '2606:4700:4700::1111' > assert rev_lookup(ip) == name E AssertionError: assert '' == 'one.one.one.one' E - one.one.one.one ```

kerem commented

2026-02-26 10:31:09 +03:00

Author

Owner

@ThomasWaldmann commented on GitHub (Mar 18, 2023):

For now, these tests will just get skipped - until we have fixed the root cause.

@ThomasWaldmann commented on GitHub (Mar 18, 2023): For now, these tests will just get skipped - until we have fixed the root cause.

kerem commented

2026-02-26 10:31:09 +03:00

Author

Owner

@ThomasWaldmann commented on GitHub (Mar 18, 2023):

Guess it has to do with the DNS / resolver setup on github CI.

If one runs these 2 tests locally without any special DNS setup, it works.

@ThomasWaldmann commented on GitHub (Mar 18, 2023): Guess it has to do with the DNS / resolver setup on github CI. If one runs these 2 tests locally without any special DNS setup, it works.

kerem referenced this issue

2026-02-26 10:31:38 +03:00

[PR #371] [MERGED] Fix stale users check #476