[GH-ISSUE #424] api.views:161 crashes #310

New issue

Closed

opened 2026-02-26 10:30:44 +03:00 by kerem · 1 comment

kerem commented

2026-02-26 10:30:44 +03:00

Owner

Originally created by @ThomasWaldmann on GitHub (Apr 9, 2019).
Original GitHub issue: https://github.com/nsupdate-info/nsupdate.info/issues/424

Originally assigned to: @ThomasWaldmann on GitHub.

    response = get_response(request)
  File "/srv/nsupdate.info/env/lib/python3.5/site-packages/django/utils/deprecation.py", line 140, in __call__
    response = self.get_response(request)
  File "/srv/nsupdate.info/env/lib/python3.5/site-packages/django/core/handlers/exception.py", line 41, in inner
    response = get_response(request)
  File "/srv/nsupdate.info/env/lib/python3.5/site-packages/django/core/handlers/base.py", line 185, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/srv/nsupdate.info/env/lib/python3.5/site-packages/django/views/generic/base.py", line 68, in view
    return self.dispatch(request, *args, **kwargs)
  File "/srv/nsupdate.info/env/lib/python3.5/site-packages/django/views/generic/base.py", line 88, in dispatch
    return handler(request, *args, **kwargs)
  File "/srv/nsupdate.info/repo/src/nsupdate/utils/log.py", line 124, in caller
    return func(*args, **kwargs)
  File "/srv/nsupdate.info/repo/src/nsupdate/api/views.py", line 221, in get
    host = check_api_auth(username, password)
  File "/srv/nsupdate.info/repo/src/nsupdate/api/views.py", line 161, in check_api_auth
    logger.warning('%s - received bad credentials (password does not match)' % (fqdn, ))
Message: 'xxx.nsupdate.info - received bad credentials (password does not match)'
Arguments: ()

Originally created by @ThomasWaldmann on GitHub (Apr 9, 2019). Original GitHub issue: https://github.com/nsupdate-info/nsupdate.info/issues/424 Originally assigned to: @ThomasWaldmann on GitHub. ``` response = get_response(request) File "/srv/nsupdate.info/env/lib/python3.5/site-packages/django/utils/deprecation.py", line 140, in __call__ response = self.get_response(request) File "/srv/nsupdate.info/env/lib/python3.5/site-packages/django/core/handlers/exception.py", line 41, in inner response = get_response(request) File "/srv/nsupdate.info/env/lib/python3.5/site-packages/django/core/handlers/base.py", line 185, in _get_response response = wrapped_callback(request, *callback_args, **callback_kwargs) File "/srv/nsupdate.info/env/lib/python3.5/site-packages/django/views/generic/base.py", line 68, in view return self.dispatch(request, *args, **kwargs) File "/srv/nsupdate.info/env/lib/python3.5/site-packages/django/views/generic/base.py", line 88, in dispatch return handler(request, *args, **kwargs) File "/srv/nsupdate.info/repo/src/nsupdate/utils/log.py", line 124, in caller return func(*args, **kwargs) File "/srv/nsupdate.info/repo/src/nsupdate/api/views.py", line 221, in get host = check_api_auth(username, password) File "/srv/nsupdate.info/repo/src/nsupdate/api/views.py", line 161, in check_api_auth logger.warning('%s - received bad credentials (password does not match)' % (fqdn, )) Message: 'xxx.nsupdate.info - received bad credentials (password does not match)' Arguments: () ```

kerem closed this issue

2026-02-26 10:30:45 +03:00

kerem commented

2026-02-26 10:30:45 +03:00

Author

Owner

@ThomasWaldmann commented on GitHub (Apr 9, 2019):

diff --git a/src/nsupdate/api/views.py b/src/nsupdate/api/views.py
index ed8d4c0..9715fe7 100644
--- a/src/nsupdate/api/views.py
+++ b/src/nsupdate/api/views.py
@@ -134,7 +134,8 @@ def basic_authenticate(auth):
     return username, password
 
 
-def check_api_auth(username, password):
+@log.logger(__name__)
+def check_api_auth(username, password, logger=None):
     """
     Check username and password against our database.

@ThomasWaldmann commented on GitHub (Apr 9, 2019): ``` diff --git a/src/nsupdate/api/views.py b/src/nsupdate/api/views.py index ed8d4c0..9715fe7 100644 --- a/src/nsupdate/api/views.py +++ b/src/nsupdate/api/views.py @@ -134,7 +134,8 @@ def basic_authenticate(auth): return username, password -def check_api_auth(username, password): +@log.logger(__name__) +def check_api_auth(username, password, logger=None): """ Check username and password against our database. ```

kerem referenced this issue

2026-02-26 10:31:33 +03:00

[PR #310] [MERGED] Update DD-WRT config instructions, fixes #300 #453