[GH-ISSUE #135] crash with invalid ip address #125

New issue

Closed

opened 2026-02-26 09:35:51 +03:00 by kerem · 1 comment

kerem commented

2026-02-26 09:35:51 +03:00

Owner

Originally created by @ThomasWaldmann on GitHub (Jan 18, 2014).
Original GitHub issue: https://github.com/nsupdate-info/nsupdate.info/issues/135

Originally assigned to: @ThomasWaldmann on GitHub.

If an invalid IP (v4 or v6) address is given to update_authorized (e.g. via myip=...), it raises an (uncatched) ValueError:

  File "/srv/nsupdate.info/repo/nsupdate/api/views.py", line 260, in get
    return _update(host, hostname, ipaddr, ssl, logger=logger)

  File "/srv/nsupdate.info/repo/nsupdate/api/views.py", line 285, in _update
    kind = check_ip(ipaddr, ('ipv4', 'ipv6'))

  File "/srv/nsupdate.info/repo/nsupdate/main/dnstools.py", line 72, in check_ip
    af = dns.inet.af_for_address(ipaddr)

  File "/srv/nsupdate.info/env/local/lib/python2.7/site-packages/dns/inet.py", line 90, in af_for_address
    raise ValueError

Originally created by @ThomasWaldmann on GitHub (Jan 18, 2014). Original GitHub issue: https://github.com/nsupdate-info/nsupdate.info/issues/135 Originally assigned to: @ThomasWaldmann on GitHub. If an invalid IP (v4 or v6) address is given to update_authorized (e.g. via myip=...), it raises an (uncatched) ValueError: ``` File "/srv/nsupdate.info/repo/nsupdate/api/views.py", line 260, in get return _update(host, hostname, ipaddr, ssl, logger=logger) File "/srv/nsupdate.info/repo/nsupdate/api/views.py", line 285, in _update kind = check_ip(ipaddr, ('ipv4', 'ipv6')) File "/srv/nsupdate.info/repo/nsupdate/main/dnstools.py", line 72, in check_ip af = dns.inet.af_for_address(ipaddr) File "/srv/nsupdate.info/env/local/lib/python2.7/site-packages/dns/inet.py", line 90, in af_for_address raise ValueError ```