[GH-ISSUE #110] strange css definition / code checker warning #103

New issue

Closed

opened 2026-02-26 09:35:42 +03:00 by kerem · 1 comment

kerem commented

2026-02-26 09:35:42 +03:00

Owner

Originally created by @ThomasWaldmann on GitHub (Dec 15, 2013).
Original GitHub issue: https://github.com/nsupdate-info/nsupdate.info/issues/110

in nsupdate.css we have:

.wrap {
min-height: 100%;
height: auto !important;
height: 100%;
...
}

Pycharm warns that the 2nd height definition overwrites the first one.

But: this css is exactly how some bootstrap example recommended to do it.

So, is this a problem? Why? What is correct?

Originally created by @ThomasWaldmann on GitHub (Dec 15, 2013). Original GitHub issue: https://github.com/nsupdate-info/nsupdate.info/issues/110 in nsupdate.css we have: .wrap { min-height: 100%; height: auto !important; height: 100%; ... } Pycharm warns that the 2nd height definition overwrites the first one. But: this css is exactly how some bootstrap example recommended to do it. So, is this a problem? Why? What is correct?

kerem

2026-02-26 09:35:42 +03:00

closed this issue
added the
needs help

task
labels

kerem commented

2026-02-26 09:35:42 +03:00

Author

Owner

@1v3ry commented on GitHub (Dec 25, 2013):

since the 100% definition is overwritten by the auto !important, you can get rid of it.
furthermore auto is the default value for the height property, so you actually can get rid of both height definitions.
smaller code, no error :)

@1v3ry commented on GitHub (Dec 25, 2013): since the 100% definition is overwritten by the auto !important, you can get rid of it. furthermore auto is the default value for the height property, so you actually can get rid of both height definitions. smaller code, no error :)

kerem referenced this issue

2026-02-26 10:31:17 +03:00

[PR #103] [CLOSED] added timestamp; removed clear-text password #390