[GH-ISSUE #142] Error in processing template records if name is '' #88

New issue

Closed

opened 2026-02-28 01:20:56 +03:00 by kerem · 3 comments

kerem commented

2026-02-28 01:20:56 +03:00

Owner

Originally created by @bajizs on GitHub (Mar 29, 2017).
Original GitHub issue: https://github.com/tuxis-ie/nsedit/issues/142

If you have empty name for some template records (for example MX record), get an API error of not canonical name.

can be solved withthis lines in zones .php (replace lines 296-298 with next lines):
foreach ($template['records'] as $record) {
$name = $record['name'];
if ('' == $name) {
$name = $zone->name;
} elseif (string_ends_with($name, '.')) {
$name = substr($name, 0, -1);
if (!string_ends_with($name, $zone->name)) {
jtable_respond(null, 'error', "Name $name not in zone ".$zone->name);
}
} else if (!string_ends_with($name, $zone->name)) {
$name = $name . '.' . $zone->name;
}
$zone->addRecord($name, $record['type'], $record['content']);
}

Originally created by @bajizs on GitHub (Mar 29, 2017). Original GitHub issue: https://github.com/tuxis-ie/nsedit/issues/142 If you have empty name for some template records (for example MX record), get an API error of not canonical name. can be solved withthis lines in zones .php (replace lines 296-298 with next lines): foreach ($template['records'] as $record) { $name = $record['name']; if ('' == $name) { $name = $zone->name; } elseif (string_ends_with($name, '.')) { $name = substr($name, 0, -1); if (!string_ends_with($name, $zone->name)) { jtable_respond(null, 'error', "Name $name not in zone ".$zone->name); } } else if (!string_ends_with($name, $zone->name)) { $name = $name . '.' . $zone->name; } $zone->addRecord($name, $record['type'], $record['content']); }

kerem closed this issue

2026-02-28 01:20:56 +03:00

kerem commented

2026-02-28 01:20:56 +03:00

Author

Owner

@tuxis-ie commented on GitHub (Mar 29, 2017):

This works for me?

        array(
            'name'      => '',
            'type'      => 'MX',
            'content'   => '10 connect.tuxis.nl.'),
        array(
            'name'      => '',
            'type'      => 'MX',
            'content'   => '20 fallback.tuxis.nl.'),

@tuxis-ie commented on GitHub (Mar 29, 2017): This works for me? ``` array( 'name' => '', 'type' => 'MX', 'content' => '10 connect.tuxis.nl.'), array( 'name' => '', 'type' => 'MX', 'content' => '20 fallback.tuxis.nl.'), ```

kerem commented

2026-02-28 01:20:56 +03:00

Author

Owner

@bajizs commented on GitHub (Mar 29, 2017):

On relase v1.1?

@bajizs commented on GitHub (Mar 29, 2017): On relase v1.1?

kerem commented

2026-02-28 01:20:56 +03:00

Author

Owner

@tuxis-ie commented on GitHub (Apr 28, 2017):