mirror of
https://github.com/tuxis-ie/nsedit.git
synced 2026-04-27 00:25:50 +03:00
[GH-ISSUE #78] Allow to disable records #45
Labels
No labels
bug
duplicate
enhancement
help wanted
invalid
pull-request
question
question
upstream
upstream
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nsedit#45
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @nickygerritsen on GitHub (Mar 19, 2016).
Original GitHub issue: https://github.com/tuxis-ie/nsedit/issues/78
First of all, great product. I really enjoy it and its simplicity.
However, would it be possible to add the option to disable a record? As far as I know this would only mean we need to set "disabled: true" when sending it to the API.
The biggest problem I currently see is that we use the whole JSON as ID for the record and that might mean the ID changes when we disable it, but maybe I'm wrong in that sense?
Disabling records would make sense for us as we sometimes want to temporarily not serve some records.
If the ID thing is not a problem, I think I might even easily be able to provide a PR and am willing to do that :).
@tuxis-ie commented on GitHub (Mar 21, 2016):
I don't think there would be an issue. Feel free to fix a pr and I'd be happy to merge it.
@tuxis-ie commented on GitHub (Mar 21, 2016):
Merged