[PR #202] [MERGED] Add missing return to Comment::export #203

New issue

Closed

opened 2026-02-28 01:21:25 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:21:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tuxis-ie/nsedit/pull/202
Author: @WilliamDEdwards
Created: 1/23/2024
Status: ✅ Merged
Merged: 1/23/2024
Merged by: @tuxis-ie

Base: master ← Head: fix/add-missing-return

📝 Commits (1)

e5a121f Add missing return to Comment::export

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 includes/class/Zone.php (+2 -0)

📄 Description

Without this return, RRSet::exportComments returns an array of null, which causes PowerDNS to return Key 'content' not present or not a String.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tuxis-ie/nsedit/pull/202 **Author:** [@WilliamDEdwards](https://github.com/WilliamDEdwards) **Created:** 1/23/2024 **Status:** ✅ Merged **Merged:** 1/23/2024 **Merged by:** [@tuxis-ie](https://github.com/tuxis-ie) **Base:** `master` ← **Head:** `fix/add-missing-return` --- ### 📝 Commits (1) - [`e5a121f`](https://github.com/tuxis-ie/nsedit/commit/e5a121f24b77e069e2eb9b88a6cfa119c4d4bf01) Add missing return to Comment::export ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `includes/class/Zone.php` (+2 -0) </details> ### 📄 Description Without this return, RRSet::exportComments returns an array of `null`, which causes PowerDNS to return `Key 'content' not present or not a String`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>